Add clippy::self_only_used_in_recursion lint
#14787
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? clippy |
pommicket
force-pushed
the
self_only_used_in_recursion
branch
2 times, most recently
from
a59c129 to
cc321f8
Compare
pommicket
force-pushed
the
self_only_used_in_recursion
branch
from
cc321f8 to
de3eac5
Compare
|
Since Samuel has already given a basic review, r? @samueltardieu |
and use it instead of clippy::only_used_in_recursion when the parameter in question is self.
pommicket
force-pushed
the
self_only_used_in_recursion
branch
from
de3eac5 to
e240635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and use it instead of
clippy::only_used_in_recursionwhen the parameter in question is self.Fixes #10370
changelog: [
only_used_in_recursion]: Don't lint if parameter isself; add pedanticself_only_used_in_recursionlint.