Skip to content

Conversation

weihanglo
Copy link
Member

12 commits in 0e93c5bf6a1d5ee7bc2af63d1afb16cd28793601..864f74d4eadcaea3eeda37a2e7f4d34de233d51e
2025-04-05 00:00:24 +0000 to 2025-04-11 20:37:27 +0000

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Apr 12, 2025

📌 Commit 52b7571 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2025
@bors
Copy link
Collaborator

bors commented Apr 12, 2025

⌛ Testing commit 52b7571 with merge 7cd6e2f...

@bors
Copy link
Collaborator

bors commented Apr 12, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 7cd6e2f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 12, 2025
@bors bors merged commit 7cd6e2f into rust-lang:master Apr 12, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 12, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1bc5618 (parent) -> 7cd6e2f (this PR)

Test differences

Show 33012 test diffs

Stage 1

  • alloc::layout_debug_shows_log2_of_alignment: pass -> [missing] (J0)
  • backtrace::tests::test_debug: pass -> [missing] (J0)
  • collections::btree::map::tests::test_cursor_mut_key: pass -> [missing] (J0)
  • collections::linked_list::tests::test_rev_iter: pass -> [missing] (J0)
  • collections::vec_deque::tests::make_contiguous_head_to_end_2: pass -> [missing] (J0)
  • f32::test_gamma: pass -> [missing] (J0)
  • f64::test_gamma: pass -> [missing] (J0)
  • iter::adapters::array_chunks::test_iterator_array_chunks_next_and_next_back: pass -> [missing] (J0)
  • iter::adapters::cycle::test_cycle: pass -> [missing] (J0)
  • iter::adapters::intersperse::test_fold_specialization_intersperse: pass -> [missing] (J0)
  • num::test_try_isizeu16: pass -> [missing] (J0)
  • num::u16::test_pow: pass -> [missing] (J0)
  • num::u64::test_div_ceil: pass -> [missing] (J0)
  • result::test_into_ok: pass -> [missing] (J0)
  • slice::test_array_windows_infer: pass -> [missing] (J0)
  • slice::test_move_iterator: pass -> [missing] (J0)
  • str::test_collect: pass -> [missing] (J0)
  • str::test_iterator_clone: pass -> [missing] (J0)
  • string::test_extend_ref: pass -> [missing] (J0)
  • vec::test_drain_out_of_bounds: pass -> [missing] (J0)
  • vec::test_flatten_clone: pass -> [missing] (J0)
  • vec::test_slice_from_ref: pass -> [missing] (J0)
  • vec::test_vec_dedup_one: pass -> [missing] (J0)
  • ascii::long::case02_lookup_table: pass -> [missing] (J1)
  • char::methods::bench_to_ascii_uppercase: pass -> [missing] (J1)
  • fs::tests::mkdir_path_already_exists_error: pass -> [missing] (J1)
  • net::tcp::tests::partial_read: pass -> [missing] (J1)
  • net::tcp::tests::tcp_clone_two_read: pass -> [missing] (J1)
  • str::char_count::ru_tiny::case02_iter_increment: pass -> [missing] (J1)
  • str::char_count::zh_small::case01_filter_count_cont_bytes: pass -> [missing] (J1)
  • vec::bench_dedup_random_1000: pass -> [missing] (J1)
  • sort::tests::stable::panic_observable_is_less_random_d2: ignore -> [missing] (J2)
  • sort::tests::unstable::deterministic_cell_i32_ascending: ignore -> [missing] (J2)
  • bit_set::tests::union_two_sets: pass -> [missing] (J3)
  • errors::verify_ast_passes_at_least_one_trait_35: pass -> [missing] (J3)
  • errors::verify_builtin_macros_test_runner_nargs_86: pass -> [missing] (J3)
  • errors::verify_codegen_ssa_invalid_monomorphization_float_to_int_unchecked_91: pass -> [missing] (J3)
  • errors::verify_codegen_ssa_invalid_monomorphization_mask_type_114: pass -> [missing] (J3)
  • errors::verify_codegen_ssa_lib_def_write_failure_10: pass -> [missing] (J3)
  • errors::verify_codegen_ssa_rlib_only_rmeta_found_41: pass -> [missing] (J3)
  • errors::verify_expand_expr_repeat_no_syntax_vars_0: pass -> [missing] (J3)
  • errors::verify_expand_not_a_meta_item_11: pass -> [missing] (J3)
  • errors::verify_metadata_no_multiple_global_alloc_46: pass -> [missing] (J3)
  • errors::verify_parse_incorrect_semicolon_0: pass -> [missing] (J3)
  • errors::verify_passes_inline_ignored_constants_9: pass -> [missing] (J3)
  • errors::verify_passes_unknown_external_lang_item_106: pass -> [missing] (J3)
  • errors::verify_session_instrumentation_not_supported_7: pass -> [missing] (J3)
  • html::render::sorted_template::tests::js_empty_array: pass -> [missing] (J3)
  • html::tests::href_relative_parts_root: pass -> [missing] (J3)
  • impl_trait_overcaptures::verify_lint_impl_trait_redundant_captures_3: pass -> [missing] (J3)
  • spec::tests::armv7_unknown_freebsd: pass -> [missing] (J3)
  • tests::single_edge: pass -> [missing] (J3)

Stage 2

  • collections::btree::map::tests::test_into_keys: [missing] -> pass (J0)
  • collections::btree::map::tests::test_iter_entering_root_twice: [missing] -> pass (J0)
  • collections::btree::map::tests::test_split_off_tiny_left_height_2: [missing] -> pass (J0)
  • collections::btree::set::tests::test_clear: [missing] -> pass (J0)
  • collections::linked_list::tests::test_show: [missing] -> pass (J0)
  • f16::test_is_finite: [missing] -> pass (J0)
  • f64::test_round_ties_even: [missing] -> pass (J0)
  • io::buffered::tests::test_buffered_reader_seek_relative: [missing] -> pass (J0)
  • io::cursor::tests::test_buf_writer_seek: [missing] -> pass (J0)
  • io::tests::cursor_read_exact_eof: [missing] -> pass (J0)
  • iter::adapters::array_chunks::test_iterator_array_chunks_rev_remainder: [missing] -> pass (J0)
  • lazy::reentrant_init: [missing] -> pass (J0)
  • num::dec2flt::large: [missing] -> pass (J0)
  • num::i8::test_le: [missing] -> pass (J0)
  • rc::get_mut: [missing] -> pass (J0)
  • rc::partial_eq: [missing] -> pass (J0)
  • slice::memchr::no_match: [missing] -> pass (J0)
  • slice::split_off_oob_range_to: [missing] -> pass (J0)
  • slice::test_chunks_exact_mut_count: [missing] -> pass (J0)
  • slice::test_push: [missing] -> pass (J0)
  • str::slice_index::boundary::rangefrom::index_fail: [missing] -> pass (J0)
  • str::test_pattern_deref_forward: [missing] -> pass (J0)
  • str::test_replace_2a: [missing] -> pass (J0)
  • time::mul: [missing] -> pass (J0)
  • char::methods::bench_to_digit_radix_16: [missing] -> pass (J1)
  • iter::bench_cycle_take_skip_sum: [missing] -> pass (J1)
  • net::tcp::tests::multiple_connect_serial: [missing] -> pass (J1)
  • slice::rotate_medium_by1: [missing] -> pass (J1)
  • slice::swap_with_slice_usize_3000: [missing] -> pass (J1)
  • str::split_closure: [missing] -> pass (J1)
  • sort::tests::stable::correct_f128_random_d20: [missing] -> ignore (J2)
  • sort::tests::stable::panic_observable_is_less_random_s95: [missing] -> ignore (J2)
  • sort::tests::unstable::correct_i32_random_d4: [missing] -> ignore (J2)
  • sort::tests::unstable::stability_i32_random_d20: [missing] -> ignore (J2)
  • sort::tests::unstable::stability_string_saw_mixed: [missing] -> ignore (J2)
  • clean::utils::tests::int_format_decimal: [missing] -> pass (J3)
  • errors::verify_builtin_macros_asm_opt_already_provided_81: [missing] -> pass (J3)
  • errors::verify_builtin_macros_env_not_defined_55: [missing] -> pass (J3)
  • errors::verify_builtin_macros_env_takes_args_54: [missing] -> pass (J3)
  • errors::verify_mir_build_lower_range_bound_must_be_less_than_upper_7: [missing] -> pass (J3)
  • errors::verify_passes_incorrect_do_not_recommend_args_2: [missing] -> pass (J3)
  • errors::verify_passes_rustc_std_internal_symbol_83: [missing] -> pass (J3)
  • errors::verify_privacy_private_interface_or_bounds_lint_6: [missing] -> pass (J3)
  • html::render::write_shared::tests::all_crates_template: [missing] -> pass (J3)
  • spec::tests::aarch64_unknown_linux_gnu_ilp32: [missing] -> pass (J3)
  • spec::tests::thumbv4t_none_eabi: [missing] -> pass (J3)
  • tests::literal_suffixes: [missing] -> pass (J3)
  • util::comments::tests::test_line_doc_comment: [missing] -> pass (J3)

(and 16410 additional test diffs)

Additionally, 16502 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Job duration changes

  1. x86_64-apple-2: 4739.0s -> 1583.6s (-66.6%)
  2. test-various: 4155.4s -> 2425.7s (-41.6%)
  3. x86_64-apple-1: 8769.5s -> 5771.7s (-34.2%)
  4. x86_64-gnu-aux: 5934.7s -> 4418.9s (-25.5%)
  5. aarch64-apple: 3701.2s -> 2796.4s (-24.4%)
  6. dist-apple-various: 9512.9s -> 7610.7s (-20.0%)
  7. i686-msvc-2: 7937.9s -> 7124.4s (-10.2%)
  8. dist-aarch64-apple: 4706.6s -> 5164.9s (9.7%)
  9. dist-x86_64-apple: 8483.7s -> 7793.3s (-8.1%)
  10. x86_64-msvc-ext3: 7447.5s -> 7843.3s (5.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@weihanglo weihanglo deleted the update-cargo branch April 12, 2025 17:09
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7cd6e2f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.3% [-3.3%, -3.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [-3.3%, 3.4%] 2

Cycles

Results (secondary 4.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.1% [4.1%, 4.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.898s -> 777.281s (0.05%)
Artifact size: 365.51 MiB -> 365.49 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants