Port #[macro_export] to the new attribute parsing infrastructure #143857

Periodic1911 · 2025-07-12T22:00:14Z

Ports macro_export to the new attribute parsing infrastructure for #131229 (comment)

r? @oli-obk

cc @JonathanBrouwer @jdonszelmann

rustbot · 2025-07-12T22:00:20Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Periodic1911 · 2025-07-12T22:07:44Z

tests/ui/attributes/invalid_macro_export_argument.rs

@@ -26,12 +22,15 @@ macro_rules! d {
 }

 #[macro_export()]
+//~^ ERROR malformed `macro_export` attribute input


This is a breaking change! Malformed macro_export attributes have had a lint since 2023 (deny(invalid_macro_export_arguments)). This PR makes this an error.
Furthermore, #[macro_export()] has been accepted since 2023, and this PR makes that an error too.

As discussed in #142838 (comment), we can make breaking changes as long as we do a crater run. So this PR needs a crater run.

bors · 2025-07-13T05:32:15Z

☔ The latest upstream changes (presumably #140717) made this pull request unmergeable. Please resolve the merge conflicts.

jdonszelmann · 2025-07-13T08:02:56Z

@Periodic1911 if you rebase I'll run a crater

jdonszelmann · 2025-07-13T08:03:54Z

@rust-lang/lang this makes a long-standing warning an error with a crater run. Just wanted to notify you

jdonszelmann · 2025-07-13T12:54:46Z

@bors try

Port #[macro_export] to the new attribute parsing infrastructure Ports macro_export to the new attribute parsing infrastructure for #131229 (comment) r? `@oli-obk` cc `@JonathanBrouwer` `@jdonszelmann`

bors · 2025-07-13T12:55:57Z

⌛ Trying commit ac1f122 with merge 723ab94...

bors · 2025-07-13T15:12:39Z

☀️ Try build successful - checks-actions
Build commit: 723ab94 (723ab942d877517caf445dafde0416803ef56501)

jdonszelmann · 2025-07-13T15:34:00Z

@craterbot check

jdonszelmann · 2025-07-27T14:37:53Z

@Periodic1911 FCP finished. if you rebase we can go for merge! :)

Periodic1911 · 2025-07-28T21:45:22Z

compiler/rustc_lint_defs/src/builtin.rs

@@ -4187,8 +4187,13 @@ declare_lint! {
    /// You can't have multiple arguments in a `#[macro_export(..)]`, or mention arguments other than `local_inner_macros`.
    ///
    pub INVALID_MACRO_EXPORT_ARGUMENTS,
-    Warn,
+    Deny,


This lint is now deny by default and FCW

Periodic1911 · 2025-07-28T21:52:15Z

@jdonszelmann rebased! And I made some changes to the parser error handling in accordance with the lang team's decision. Did I comply exactly with what they had in mind?

Periodic1911 · 2025-07-28T21:56:13Z

tests/ui/attributes/invalid_macro_export_argument.allow.stderr

@@ -0,0 +1,40 @@
+Future incompatibility report: Future breakage diagnostic:


Although the invalid_macro_export_argument.rs test passes (check-pass) with #![allow(invalid_macro_export_arguments)], it also prints FCWs to stderr

jdonszelmann · 2025-07-30T18:28:12Z

compiler/rustc_attr_parsing/src/attributes/macro_attrs.rs

+
+    fn convert(cx: &mut AcceptContext<'_, '_, S>, args: &ArgParser<'_>) -> Option<AttributeKind> {
+        let suggestions =
+            <Self as SingleAttributeParser<S>>::TEMPLATE.suggestions(false, "macro_export");


might be nice to only compute this when emitting the lint since that's quite uncommon. You could reduce deduplication by putting this code in a closure or macro.

jdonszelmann · 2025-07-30T18:43:48Z

tests/ui/attributes/malformed-attrs.rs

@@ -213,7 +213,8 @@ extern crate wloop;
 //~^ ERROR can't find crate for `wloop` [E0463]

 #[macro_export = 18]
-//~^ ERROR malformed `macro_export` attribute input
+//~^ ERROR valid forms for the attribute are
+//~| WARN this was previously accepted by the compiler


I think this isn't very nice. It took me a while to see that this really was a problem, tried some things to make sure. But this was already an error, not a warning. Only the #[macro_export(meow)] was a warning that will become an error. For this form, the compiler already gave an error and now we're getting an error, plus also a warning that it'll be an error in the future. I don't think that's right

bors · 2025-07-31T20:51:21Z

☔ The latest upstream changes (presumably #144740) made this pull request unmergeable. Please resolve the merge conflicts.

Periodic1911 · 2025-08-01T08:14:25Z

compiler/rustc_attr_parsing/src/attributes/macro_attrs.rs

+
+    fn convert(cx: &mut AcceptContext<'_, '_, S>, args: &ArgParser<'_>) -> Option<AttributeKind> {
+        let suggestions =
+            || <Self as SingleAttributeParser<S>>::TEMPLATE.suggestions(false, "macro_export");


It's a closure now :)

Periodic1911 · 2025-08-01T08:17:07Z

tests/ui/attributes/malformed-attrs.rs

-//~^ ERROR malformed `macro_export` attribute input
+//~^ ERROR valid forms for the attribute are


You were right, this was always an error. I checked on stable, and the invalid_macro_export_arguments lint does not handle this

rustbot · 2025-08-01T12:14:39Z

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

jdonszelmann · 2025-08-01T12:22:29Z

I expect the tests introduced by this PR to fail
#144700

jdonszelmann · 2025-08-01T12:25:26Z

r=me after that, @bors delegate+

bors · 2025-08-01T12:25:30Z

✌️ @Periodic1911, you can now approve this pull request!

If @jdonszelmann told you to "r=me" after making some further change, please make that change, then do @bors r=@jdonszelmann

Periodic1911 · 2025-08-01T14:30:59Z

@bors r=@jdonszelmann

bors · 2025-08-01T14:31:02Z

📌 Commit 90fad60 has been approved by jdonszelmann

It is now in the queue for this repository.

rustbot assigned oli-obk Jul 12, 2025

Periodic1911 commented Jul 12, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Periodic1911 force-pushed the macro-export branch from 12474a6 to bb6c5dd Compare July 12, 2025 22:22

This comment has been minimized.

Sign in to view

jdonszelmann mentioned this pull request Jul 13, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

jdonszelmann added T-lang Relevant to the language team I-lang-nominated Nominated for discussion during a lang team meeting. labels Jul 13, 2025

Periodic1911 force-pushed the macro-export branch from bb6c5dd to 92071cc Compare July 13, 2025 10:27

rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Jul 13, 2025

Periodic1911 force-pushed the macro-export branch from 92071cc to ac1f122 Compare July 13, 2025 10:33

rustbot mentioned this pull request Jul 26, 2025

Tracking issue for release notes of #143857: Port #[macro_export] to the new attribute parsing infrastructure #144505

Open

oli-obk assigned jdonszelmann and unassigned oli-obk Jul 28, 2025

Periodic1911 force-pushed the macro-export branch from ac1f122 to f9b9221 Compare July 28, 2025 21:44

rustbot added T-clippy Relevant to the Clippy team. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jul 28, 2025

Periodic1911 commented Jul 28, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Periodic1911 force-pushed the macro-export branch from f9b9221 to 943b384 Compare July 29, 2025 08:15

jdonszelmann requested changes Jul 30, 2025

View reviewed changes

jdonszelmann mentioned this pull request Jul 31, 2025

rustdoc-json: Move #[macro_export] from Other to it's own variant #144700

Merged

Periodic1911 force-pushed the macro-export branch from 943b384 to d62190a Compare August 1, 2025 08:12

Periodic1911 commented Aug 1, 2025

View reviewed changes

Periodic1911 force-pushed the macro-export branch from d62190a to 7a67892 Compare August 1, 2025 12:14

This comment has been minimized.

Sign in to view

Port #[macro_export] to the new attribute parsing infrastructure

90fad60

Periodic1911 force-pushed the macro-export branch from 7a67892 to 90fad60 Compare August 1, 2025 12:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 1, 2025

		@@ -0,0 +1,40 @@
		Future incompatibility report: Future breakage diagnostic:

		//~^ ERROR malformed `macro_export` attribute input
		//~^ ERROR valid forms for the attribute are

Port #[macro_export] to the new attribute parsing infrastructure #143857

Are you sure you want to change the base?

Port #[macro_export] to the new attribute parsing infrastructure #143857

Conversation

Periodic1911 commented Jul 12, 2025

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

Periodic1911 Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 27, 2025

Uh oh!

Periodic1911 Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Periodic1911 commented Jul 28, 2025

Uh oh!

Periodic1911 Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

jdonszelmann Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

bors commented Jul 31, 2025

Uh oh!

Periodic1911 Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Periodic1911 Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

rustbot commented Aug 1, 2025

Uh oh!

jdonszelmann commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

This comment has been minimized.

Periodic1911 commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

Uh oh!

Periodic1911 Jul 12, 2025 •

edited

Loading

Periodic1911 Jul 28, 2025 •

edited

Loading

jdonszelmann commented Aug 1, 2025 •

edited

Loading