-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Some let chains
clean-up
#144469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Some let chains
clean-up
#144469
Conversation
Some changes occurred to constck cc @fee1-dead Some changes occurred in match checking cc @Nadrieril Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred to the CTFE machinery HIR ty lowering was modified cc @fmease Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs |
This comment has been minimized.
This comment has been minimized.
Thanks for your work! Could you split the change to a few commits to make it easier for review(and for merging)? |
Well, I've found some time, did you mean to split commits like this (I'll reword them later if needed)? Or like... different PRs? |
One PR is enough. But TBH I don't see some real benefit from doing these clean-ups, since they don't significantly reduce the number of lines of code. And it may change the logic of the original design. For example, developers may add some |
OK. From this point of view, instead of thinking "why do this", maybe it is better to answer "why not do this" :) |
@SparrowLii I'm pretty sure I've splitted this PR already into separate commits, this one is 3 commits instead of 1. If you meant something different by splitting PR please could you explain then |
Not sure if this kind of clean-up is welcoming because of size, but I decided to try out one
r? compiler