Implement `stability_implications` without a visitor. #144873

cjgillot · 2025-08-03T22:09:23Z

Since #143845, the Annotator visitor was a no-op when the crate is not staged_api. This PR avoids using a visitor altogether, making stability_implications truly a no-op in most cases.

cjgillot · 2025-08-03T22:19:24Z

@bors try @rust-timer queue

rust-bors · 2025-08-03T22:19:28Z

⌛ Trying commit 36f2045 with merge 6c6c56e…

To cancel the try build, run the command @bors try cancel.

Implement `stability_implications` without a visitor.

rust-bors · 2025-08-04T00:34:36Z

☀️ Try build successful (CI)
Build commit: 6c6c56e (6c6c56ef12ea98dddfc1fce7376b22dd2ee0a32b, parent: f34ba774c78ea32b7c40598b8ad23e75cdac42a6)

rust-timer · 2025-08-04T06:18:52Z

Finished benchmarking commit (6c6c56e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-0.2%	[-0.4%, -0.2%]	29
Improvements ✅ (secondary)	-0.3%	[-1.0%, -0.0%]	46
All ❌✅ (primary)	-0.2%	[-0.4%, -0.2%]	29

Max RSS (memory usage)

Results (primary -1.0%, secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	4.3%	[2.2%, 5.6%]	6
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.8%]	1
All ❌✅ (primary)	-1.0%	[-2.4%, 0.4%]	2

Cycles

Results (primary -2.2%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-2.2%	[-2.8%, -1.6%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.8%, -1.6%]	3

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 467.629s -> 465.94s (-0.36%)
Artifact size: 376.97 MiB -> 376.94 MiB (-0.01%)

rustbot · 2025-08-04T11:00:44Z

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

lqd

Looking good, r=me w/ nit

lqd · 2025-08-04T11:43:00Z

compiler/rustc_hir/src/def.rs

@@ -313,6 +318,42 @@ impl DefKind {
        )
    }

+    pub fn has_generics(self) -> bool {


maybe there can be a better name, like can contain generics or something? + a doc comment, e.g. at least mentioning generics_of

I modeled the name after pre-existing has_codegen_attrs. Added a doc-comment.

lqd · 2025-08-04T23:23:01Z

🚀

@bors r+

bors · 2025-08-04T23:23:03Z

📌 Commit d5f2260 has been approved by lqd

It is now in the queue for this repository.

Implement `stability_implications` without a visitor. Since #143845, the `Annotator` visitor was a no-op when the crate is not staged_api. This PR avoids using a visitor altogether, making `stability_implications` truly a no-op in most cases.

bors · 2025-08-08T09:39:19Z

⌛ Testing commit d5f2260 with merge fbf65d2...

rust-log-analyzer · 2025-08-08T11:20:22Z

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- f32::test_gamma stdout ----

thread 'f32::test_gamma' (194677) panicked at library/std/tests/floats/f32.rs:198:5:
2.0000012 is not approximately equal to 2.0 (threshold 1e-6, difference 1.1920929e-6)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
note: in Miri, you may have to set `MIRIFLAGS=-Zmiri-env-forward=RUST_BACKTRACE` for the environment variable to have an effect


failures:
    f32::test_gamma

test result: FAILED. 28 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 4.76s

error: test failed, to rerun pass `-p std --test floats`
Build completed unsuccessfully in 0:04:35
make: *** [Makefile:58: check-aux] Error 1
  local time: Fri Aug  8 11:20:10 UTC 2025
  network time: Fri, 08 Aug 2025 11:20:10 GMT
##[error]Process completed with exit code 2.
Post job cleanup.

bors · 2025-08-08T11:20:59Z

💔 Test failed - checks-actions

Kobzol · 2025-08-08T20:53:21Z

@bors retry

bors · 2025-08-10T05:44:57Z

⌛ Testing commit d5f2260 with merge 8712e45...

bors · 2025-08-10T08:44:54Z

☀️ Test successful - checks-actions
Approved by: lqd
Pushing 8712e45 to master...

github-actions · 2025-08-10T08:48:34Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 915a766 (parent) -> 8712e45 (this PR)

Test differences

Show 11 test diffs

11 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8712e4567551a2714efa66dac204ec7137bc5605 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 8063.8s -> 5786.0s (-28.2%)
x86_64-apple-2: 5874.6s -> 4566.7s (-22.3%)
dist-apple-various: 4428.3s -> 3691.6s (-16.6%)
dist-x86_64-apple: 10569.0s -> 8861.6s (-16.2%)
x86_64-apple-1: 7223.5s -> 8159.0s (13.0%)
x86_64-gnu-llvm-19: 2883.9s -> 2589.9s (-10.2%)
dist-loongarch64-musl: 5497.4s -> 5084.7s (-7.5%)
dist-riscv64-linux: 5090.6s -> 4735.3s (-7.0%)
dist-aarch64-apple: 6853.5s -> 6400.6s (-6.6%)
x86_64-mingw-2: 8335.7s -> 7833.6s (-6.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-08-10T10:45:15Z

Finished benchmarking commit (8712e45): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.1%]	41
Improvements ✅ (secondary)	-0.9%	[-3.0%, -0.2%]	26
All ❌✅ (primary)	-0.3%	[-0.3%, -0.1%]	41

Max RSS (memory usage)

Results (primary -2.3%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-2.3%	[-3.4%, -1.5%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.3%	[-3.4%, -1.5%]	4

Cycles

Results (primary -2.6%, secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 463.478s -> 462.592s (-0.19%)
Artifact size: 377.38 MiB -> 377.39 MiB (0.00%)

Implement stability_implications without a visitor.

36f2045

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 3, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 3, 2025

Auto merge of #144873 - cjgillot:implications, r=<try>

6c6c56e

Implement `stability_implications` without a visitor.

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 3, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 4, 2025

cjgillot marked this pull request as ready for review August 4, 2025 11:00

rustbot assigned SparrowLii Aug 4, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2025

lqd approved these changes Aug 4, 2025

View reviewed changes

Add doc-comment.

d5f2260

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 8, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 10, 2025

bors merged commit 8712e45 into rust-lang:master Aug 10, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Aug 10, 2025

cjgillot deleted the implications branch August 10, 2025 15:23

Implement stability_implications without a visitor. #144873

Implement stability_implications without a visitor. #144873

Uh oh!

Conversation

cjgillot commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjgillot commented Aug 3, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 3, 2025

Uh oh!

rust-bors bot commented Aug 4, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Aug 4, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

rustbot commented Aug 4, 2025

Uh oh!

lqd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lqd commented Aug 4, 2025

Uh oh!

bors commented Aug 4, 2025

Uh oh!

bors commented Aug 8, 2025

Uh oh!

rust-log-analyzer commented Aug 8, 2025

Uh oh!

bors commented Aug 8, 2025

Uh oh!

Kobzol commented Aug 8, 2025

Uh oh!

bors commented Aug 10, 2025

Uh oh!

bors commented Aug 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 10, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Aug 10, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

Uh oh!

Implement `stability_implications` without a visitor. #144873

Implement `stability_implications` without a visitor. #144873

cjgillot commented Aug 3, 2025 •

edited

Loading