Skip to content

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Oct 8, 2025

These tools aren't included in a default x check, but checking them locally is still useful for maintainers working on the tools themselves:

  • bootstrap
  • bump-stage0
  • compiletest
  • coverage-dump
  • linkchecker
  • run-make-support
  • rustdoc-gui-test

This PR therefore explicitly checks them in one CI job, to ensure that check builds for them continue to work.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 8, 2025
@Kobzol
Copy link
Member

Kobzol commented Oct 8, 2025

r? @Kobzol

@rustbot rustbot assigned Kobzol and unassigned Mark-Simulacrum Oct 8, 2025
@Zalathar Zalathar force-pushed the check-bootstrap-tools branch 2 times, most recently from a2034af to ebb52ff Compare October 9, 2025 01:44
This is useful for ensuring that changes to compiletest haven't broken
rustdoc-gui-test.
@Zalathar Zalathar force-pushed the check-bootstrap-tools branch from ebb52ff to c7b4c83 Compare October 9, 2025 08:58
@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Zalathar Zalathar force-pushed the check-bootstrap-tools branch from c7b4c83 to 0be0a0a Compare October 9, 2025 09:02
@Kobzol
Copy link
Member

Kobzol commented Oct 9, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 9, 2025

📌 Commit 0be0a0a has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2025
bors added a commit that referenced this pull request Oct 9, 2025
Rollup of 3 pull requests

Successful merges:

 - #147446 (PassWrapper: use non-deprecated lookupTarget method)
 - #147473 (Do `x check` on various bootstrap tools in CI)
 - #147509 (remove intrinsic wrapper functions from LLVM bindings)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 84590ef into rust-lang:master Oct 9, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 9, 2025
rust-timer added a commit that referenced this pull request Oct 9, 2025
Rollup merge of #147473 - Zalathar:check-bootstrap-tools, r=Kobzol

Do `x check` on various bootstrap tools in CI

These tools aren't included in a default `x check`, but checking them locally is still useful for maintainers working on the tools themselves:

- bootstrap
- bump-stage0
- compiletest
- coverage-dump
- linkchecker
- run-make-support
- rustdoc-gui-test

This PR therefore explicitly checks them in one CI job, to ensure that check builds for them continue to work.
@Zalathar Zalathar deleted the check-bootstrap-tools branch October 10, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants