Adapt tests to fixest v0.13.0 #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fixest v0.13.0, the new default is to remove the fixed-effects singletons. In the current test it leads to the removal of one observation, which was not the case previously, hence 3 tests not passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @kylebutts and @s3alfisc,
fixestv0.13.0, introduces a few breaking changes.One is that the new default is to remove the fixed-effects singletons.
I have added the argument
fixef.rm = "none"to a test in tests/testthat/test-r-vs-stata.R.Indeed, in that test the new default leads to the removal of one observation, which was not the case previously, hence 3 tests not passing.
I don't think there is another side-effect on this project.
Thanks!