Add initialValues option to toggle use of type specific initial values

[manisatwick]

Add initialValues template option , set to false to not use type specific initial values.Defaults to true

[manisatwick]

Hi @sagold , Can you please look into the PR and let me know your comments. This enables to control the inclusion of type specific values in getData response

[sagold]

Hi Mani,

thank you for your PR! I am waiting for some spare time review your MR.

Cheers,
Sascha

[manisatwick]

Hi @sagold,

Could you please review the merge request at your earliest convenience? I'm currently waiting on this change to proceed further.

Thanks in advance!
Best,
Mani

[manisatwick]

Hi @sagold ,
Can you please review the merge request ?

Thanks,
Mani

[sagold]

Hi Mani,

FYI I will do so this week.

Cheers,
Sascha

[manisatwick]

Thanks @sagold , waiting for it 🙂 .

[sagold]

Overall I agree with this merge request. This feature is likely to changed in the future in favor of a more consistent configuration (between required, optional properties, valid and invalid default values and now our new option). But right now, I am happy that you addressed this missing requirement and happy to change the api to support this.

Please note:

• as mentioned above, we can do better with the naming of the option
• all tests must pass (yarn test). For some reason your branch fails for draft tests. Unfortunately this is not yet done for MR.
• With dynamic schemas there is potential for gaps of this option - we should keep an eye on this

Cheers.
Sascha

[manisatwick]

Hi Sascha,
I have found the issue and now tests are passing. Also renamed the option as useTypeDefaults . Can you please review and let me know if further changes are required.

Thanks,
Mani