-
Notifications
You must be signed in to change notification settings - Fork 5
MDRange iteration order transformation #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cwpearson
wants to merge
37
commits into
sandialabs:main
Choose a base branch
from
cwpearson:feature/mdrange-memory-access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
MDRange iteration order transformation #49
cwpearson
wants to merge
37
commits into
sandialabs:main
from
cwpearson:feature/mdrange-memory-access
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
vmiheer
reviewed
Dec 20, 2024
mlir/lib/Dialect/Kokkos/Transforms/KokkosMdrangeIterationPass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
224c3e2
to
9f938d0
Compare
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
1a84988
to
856f904
Compare
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
faf3874
to
e878b59
Compare
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Work in progress
I'll squash / tidy this up once it's ready to go.
Improves memory access locality for GPUs.
Cost
of amemref
is modeled as its reuse distance scaled by loop trip count and whether it's a load or storememref
is the partial derivative of it's offset w.r.t the right-most induction variable of the enclosingscf.parallel
memref
index variable) for all of thememref
's index variablesmemref
index variable)/d(scf.parallel
induction variable) for all of thememref
's index variablesscf.parallel
induction variable)Cost
will usually include unknownmemref
extents and loop trip countsscf.parallel
) -> trip countmemref
,induction variable
) ->Cost
, to refer to in phase 2scf.parallel
memrefs
scf.parallel
things