Skip to content

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 11, 2025

Description:

  • The datastore routes were attempted without auth, not prompting the user for a token. adding require_auth=true for use cases that can never work without token
  • Remove datastore-specific tokens. The datastore can accept the main user auth token anyway.

I’m uncertain about the remaining usages without require_auth. For public datasets/annotations, they don’t need to prompt the user for tokens, but private ones won’t work without them. Not sure what we should do in this case.

Issues:

Todos:

  • Updated Changelog
  • Added / Updated Tests

@fm3 fm3 self-assigned this Sep 11, 2025
Copy link

github-actions bot commented Sep 11, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
9327 7808 84% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
webknossos/webknossos/client/_upload_dataset.py 82% 🟢
webknossos/webknossos/client/api_client/datastore_api_client.py 82% 🟢
webknossos/webknossos/client/api_client/models.py 100% 🟢
webknossos/webknossos/client/api_client/wk_api_client.py 89% 🟢
webknossos/webknossos/client/context.py 90% 🟢
webknossos/webknossos/dataset/dataset.py 80% 🟢
webknossos/webknossos/utils.py 71% 🟢
TOTAL 85% 🟢

updated for commit: 4fc9848 by action🐍

@fm3 fm3 requested a review from normanrz September 11, 2025 11:54
@fm3 fm3 marked this pull request as ready for review September 11, 2025 12:15
@fm3 fm3 merged commit 9d65d3f into master Sep 15, 2025
26 checks passed
@fm3 fm3 deleted the datastore-auth-token branch September 15, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants