-
Notifications
You must be signed in to change notification settings - Fork 29
update backend dependencies, fix typos with codespell #8991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughChanges include switching host parsing from URL to URI in inviteMail, updating Scala/JDK targets and plugins, bumping multiple library versions, fixing a test path typo, and correcting typos in unreleased change notes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
unreleased_changes/8880.md (1)
2-2
: Minor wording tweak for clarity (optional).Consider rephrasing to read more naturally.
-- Change that WEBKNOSSOS takes mapping types more friendly and defaults back to HDF5 in case the type is unknown. +- Change that WEBKNOSSOS handles mapping types more gracefully and defaults to HDF5 if the type is unknown.build.sbt (1)
8-8
: Targeting Java 21: ensure toolchains use JDK 21.Confirm CI images, Docker base, and dev machines use JDK 21; otherwise -release:21 will fail compilation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
app/mail/DefaultMails.scala
(2 hunks)build.sbt
(1 hunks)project/Dependencies.scala
(4 hunks)project/build.properties
(1 hunks)project/plugins.sbt
(2 hunks)test/backend/UPathTestSuite.scala
(1 hunks)unreleased_changes/8880.md
(1 hunks)unreleased_changes/8981.md
(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
test/backend/UPathTestSuite.scala (1)
webknossos-datastore/app/com/scalableminds/webknossos/datastore/helpers/UPath.scala (1)
UPath
(54-96)
🔇 Additional comments (5)
unreleased_changes/8981.md (1)
2-2
: LGTM.Typo fix looks correct.
test/backend/UPathTestSuite.scala (1)
11-11
: LGTM.Assertion path typo fixed correctly.
project/build.properties (1)
1-1
: sbt bump looks fine.No concerns from this change alone.
project/plugins.sbt (1)
2-2
: No dependency-check task references found.
Search fordependencyCheck
/dependency-check
yielded only the plugin declaration; CI/build scripts are unaffected.project/Dependencies.scala (1)
16-16
: Bumped dependency versions verified com.google.code.gson:gson 2.13.2 is confirmed as the latest published release; no discrepancies found in the other version bumps.
Steps to test:
--