Skip to content

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 13, 2025

Steps to test:

  • CI

--

  • Needs datastore update after deployment

@fm3 fm3 self-assigned this Oct 13, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 13, 2025

📝 Walkthrough

Walkthrough

Changes include switching host parsing from URL to URI in inviteMail, updating Scala/JDK targets and plugins, bumping multiple library versions, fixing a test path typo, and correcting typos in unreleased change notes.

Changes

Cohort / File(s) Summary
Mail invite URI parsing
app/mail/DefaultMails.scala
Replace URL-based host extraction with URI-based parsing in inviteMail; fallback behavior unchanged.
Dependencies versions
project/Dependencies.scala
Increment versions for Play, play-json, Gson, Google Cloud Storage, zstd-jni, PostgreSQL JDBC, webauthn4j-core (with exclusion kept), jwt-play-json, Brotli, and AWS SDK. No structural changes.
Build config and plugins
build.sbt, project/build.properties, project/plugins.sbt
Update scalac release target to 21; remove dependencyCheckAssemblyAnalyzerEnabled; bump sbt to 1.11.7; update Play sbt plugin to 3.0.9; switch dependency-check plugin group/version; bump scalapb compilerplugin.
Test fix
test/backend/UPathTestSuite.scala
Correct expected path string typo: “elsewehere” → “elsewhere”.
Unreleased notes typos
unreleased_changes/8880.md, unreleased_changes/8981.md
Fix misspellings and punctuation in changelog entries.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

backend, dependencies

Suggested reviewers

  • frcroth
  • MichaelBuessemeyer

Poem

I nibbled through URLs to find a better key,
Swapped them for URIs—crisper, bug-free.
Plugins hopped forward, deps took a leap,
Tests now spell “elsewhere,” tidy and neat.
With paws on the build and whiskers a-twitch,
This bunny signs off—versioned and rich. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately summarizes the main changes by highlighting dependency updates and typo fixes carried out using codespell, matching the core modifications in the pull request without extraneous detail.
Description Check ✅ Passed The description provides relevant testing information related to the pull request by specifying CI validation steps and a post-deployment datastore update requirement, which aligns with the nature of the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backend-deps-2025-10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fm3 fm3 marked this pull request as ready for review October 14, 2025 07:53
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
unreleased_changes/8880.md (1)

2-2: Minor wording tweak for clarity (optional).

Consider rephrasing to read more naturally.

-- Change that WEBKNOSSOS takes mapping types more friendly and defaults back to HDF5 in case the type is unknown.
+- Change that WEBKNOSSOS handles mapping types more gracefully and defaults to HDF5 if the type is unknown.
build.sbt (1)

8-8: Targeting Java 21: ensure toolchains use JDK 21.

Confirm CI images, Docker base, and dev machines use JDK 21; otherwise -release:21 will fail compilation.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05299c4 and c472c88.

📒 Files selected for processing (8)
  • app/mail/DefaultMails.scala (2 hunks)
  • build.sbt (1 hunks)
  • project/Dependencies.scala (4 hunks)
  • project/build.properties (1 hunks)
  • project/plugins.sbt (2 hunks)
  • test/backend/UPathTestSuite.scala (1 hunks)
  • unreleased_changes/8880.md (1 hunks)
  • unreleased_changes/8981.md (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
test/backend/UPathTestSuite.scala (1)
webknossos-datastore/app/com/scalableminds/webknossos/datastore/helpers/UPath.scala (1)
  • UPath (54-96)
🔇 Additional comments (5)
unreleased_changes/8981.md (1)

2-2: LGTM.

Typo fix looks correct.

test/backend/UPathTestSuite.scala (1)

11-11: LGTM.

Assertion path typo fixed correctly.

project/build.properties (1)

1-1: sbt bump looks fine.

No concerns from this change alone.

project/plugins.sbt (1)

2-2: No dependency-check task references found.
Search for dependencyCheck/dependency-check yielded only the plugin declaration; CI/build scripts are unaffected.

project/Dependencies.scala (1)

16-16: Bumped dependency versions verified com.google.code.gson:gson 2.13.2 is confirmed as the latest published release; no discrepancies found in the other version bumps.

@fm3 fm3 requested a review from normanrz October 15, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant