Backport to branch(3.16) : Use PostgreSQL in integration tests by default #2898
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request backports a change to configure JDBC-based integration tests to use PostgreSQL as the default database. This ensures that the test suite primarily validates functionality against a PostgreSQL environment by default, aligning with updated testing priorities.
Highlights
- Integration Test Configuration: The default JDBC connection parameters for integration tests have been updated to use PostgreSQL instead of MySQL. This includes changes to the default URL, username, and password.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request is an automated backport to switch the default database for integration tests from MySQL to PostgreSQL. The changes correctly update the default JDBC connection URL, username, and password in JdbcEnv.java and MultiStorageEnv.java. I have one suggestion regarding a pre-existing naming inconsistency in MultiStorageEnv.java to improve code clarity.
| private static final String DEFAULT_JDBC_CONTACT_POINT = "jdbc:mysql://localhost:3306/"; | ||
| private static final String DEFAULT_JDBC_USERNAME = "root"; | ||
| private static final String DEFAULT_JDBC_PASSWORD = "mysql"; | ||
| private static final String DEFAULT_JDBC_CONTACT_POINT = "jdbc:postgresql://localhost:5432/"; |
There was a problem hiding this comment.
The constant name DEFAULT_JDBC_CONTACT_POINT is misleading as it holds a full JDBC URL, not just a contact point. For consistency with JdbcEnv.java, which uses DEFAULT_JDBC_URL, consider renaming it to DEFAULT_JDBC_URL. This would improve clarity.
This is an automated backport of the following:
Please merge this PR after all checks have passed.