Skip to content

test: migrate from unittest to pytest, add VCR, and set up nightly test workflow #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

test: migrate from unittest to pytest, add VCR, and set up nightly test workflow #1169

wants to merge 33 commits into from

Conversation

Laure-di
Copy link
Contributor

@Laure-di Laure-di commented Aug 20, 2025 •
edited
Loading

close #849
close #1040
close #919
close #1069

@Laure-di Laure-di requested review from a team and remyleone as code owners August 20, 2025 09:56
@github-actions github-actions bot added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Aug 20, 2025
remyleone
remyleone reviewed Aug 20, 2025
View reviewed changes
@Laure-di Laure-di requested a review from a team as a code owner August 22, 2025 08:21
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Aug 22, 2025
@github-actions github-actions bot added the k8s Kubernetes Kapsule issues, bugs and feature requests label Aug 27, 2025
@Laure-di Laure-di force-pushed the test-vcrpy branch 2 times, most recently from 88a8b79 to 3f348cb Compare August 27, 2025 13:12
@Laure-di Laure-di force-pushed the test-vcrpy branch 2 times, most recently from 1f0d747 to 9b1eff6 Compare August 27, 2025 14:49
remyleone
remyleone reviewed Aug 27, 2025
View reviewed changes
.github/workflows/nightly.yml
env:
SLACK_WEBHOOK_NIGHTLY: ${{ secrets.SLACK_WEBHOOK_NIGHTLY }}
FAILED_PRODUCT: ${{ matrix.products }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up all the new lines at the end of the file

scaleway/scaleway/instance/v1/tests/cassettes/instance_volume.cassette.yaml
headers:
Accept-Encoding:
- gzip, deflate
Connection:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the useless header be cleaned up before being commited?

@remyleone
Copy link
Member

Should the run of the test be working if there are cassettes present

           ValueError: Invalid secrets, access_key & secret_key must be defined. See https://www.scaleway.com/docs/console/my-project/how-to/generate-api-key

@Laure-di Laure-di force-pushed the test-vcrpy branch 4 times, most recently from 2c69fe8 to fdb741f Compare August 28, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
2 participants
@Laure-di @remyleone