Skip to content

Fixes bug in greedy selector when scores are degenerate #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 15, 2025
Merged

Conversation

ceriottm
Copy link
Collaborator

@ceriottm ceriottm commented Jul 14, 2025

Fixes #206 . Taken over from #224 that was pulling from main which is a pain to develop for in a repo with many remotes.
Thanks @jwa7 for adding all tests, this is fixed in a slightly different (and slightly simple manner).

Contributor (creator of PR) checklist

  • Tests updated (for new features and bugfixes)?
  • Issue referenced (for PRs that solve an issue)?

For Reviewer

  • CHANGELOG updated if important change?

📚 Documentation preview 📚: https://scikit-matter--265.org.readthedocs.build/en/265/

Copy link
Collaborator

@jwa7 jwa7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up! I re-ran Alex's example in #206 and all seems good

@ceriottm ceriottm requested a review from jwa7 July 15, 2025 10:05
@ceriottm ceriottm merged commit 1c72ba5 into main Jul 15, 2025
11 checks passed
@ceriottm ceriottm deleted the bugfix/greedy branch July 15, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero scores result in repeated selection and wrong scores at least for FPS
2 participants