Skip to content

BUG: small patch to _VarArray while inputting a matrix with length > 1 #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

BUG: small patch to _VarArray while inputting a matrix with length > 1 #1060

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36e9066
Fix _VarArray size initialization logic
Zeroto521 Aug 20, 2025
23d4344
Add test for knapsack constraint with matrix variables
Zeroto521 Aug 20, 2025
b55445d
Merge branch 'master' into fix/1043
Joao-Dionisio Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pyscipopt/scip.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@
if rc == SCIP_OKAY:
pass
elif rc == SCIP_ERROR:
raise Exception('SCIP: unspecified error!')

Check failure on line 311 in src/pyscipopt/scip.pxi

View workflow job for this annotation

GitHub Actions / test-coverage (3.11) 

SCIP: unspecified error!
elif rc == SCIP_NOMEMORY:
raise MemoryError('SCIP: insufficient memory error!')
elif rc == SCIP_READERROR:
Expand Down Expand Up @@ -2509,8 +2509,8 @@
else:
raise TypeError(f"Expected Variable or list of Variable, got {type(vars)}.")

if vars:
self.size = len(vars)
self.size = len(vars)
if self.size:
self.ptr = <SCIP_VAR**> malloc(self.size * sizeof(SCIP_VAR*))
for i, var in enumerate(vars):
if not isinstance(var, Variable):
Expand Down
11 changes: 11 additions & 0 deletions tests/test_cons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,17 @@ def test_cons_indicator_with_matrix_binvar():

assert m.isEQ(m.getVal(x), 1)

def test_cons_knapsack_with_matrix_vars():
# test matrix variable vars #1043
m = Model()
vars = m.addMatrixVar(3, vtype="B")
m.addConsKnapsack(vars, [1, 2, 3], 5)

m.setObjective(vars.sum(), "maximize")
m.optimize()

assert (m.getVal(vars) == [0, 1, 1]).all()

@pytest.mark.xfail(
reason="addConsIndicator doesn't behave as expected when binary variable is False. See Issue #717."
)
Expand Down