Skip to content

Conversation

@pravic
Copy link
Member

@pravic pravic commented Apr 25, 2021

Fixes #297.
Closes #298.

@pravic pravic added sciter-engine Issues related to the Sciter Engine itself Critical Critical bugs labels Apr 25, 2021
@pravic pravic self-assigned this Apr 25, 2021
@pravic pravic marked this pull request as ready for review April 26, 2021 15:36
@AshfordN
Copy link
Contributor

AshfordN commented Apr 27, 2021

Perhaps this is an appropriate time to introduce versioning? I haven't gotten around to doing the PR, but it shouldn't be that hard, and this code change is bound to break existing code and cause confusion, as seen in #298.

@pravic
Copy link
Member Author

pravic commented Apr 27, 2021

@AshfordN Probably.

@AshfordN
Copy link
Contributor

@pravic from my understanding all you need to do is create a go.mod file, run go mod tidy to define the dependencies and create a new release version. This would allow you to merge the breaking changes in the two outstanding PRs. It should be an easy fix from your end.

@pravic
Copy link
Member Author

pravic commented Jul 19, 2021

Thanks. Will do.

@dosgo
Copy link

dosgo commented Jan 28, 2022

No one handles this merger? It seems that the old version of sciter cannot be downloaded at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical Critical bugs sciter-engine Issues related to the Sciter Engine itself

Development

Successfully merging this pull request may close these issues.

the example crash 4.4.7.0 SciterAPI

4 participants