Skip to content

Conversation

scott-the-programmer
Copy link
Owner

@scott-the-programmer scott-the-programmer commented Jul 29, 2025

Closes #202

Some parts of minikube uses the node port rather than the kube config port e.g. https://github.com/kubernetes/minikube/blob/fbf257d1b5a19309d0e75e02eae245f33885345d/pkg/minikube/registry/drvs/docker/docker.go#L86-L87

This is fine, however, I naively set the initial node to 8443, thinking it would be changed down stream during the provision set. This is clearly not the case

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an inconsistency in API server port configuration by ensuring both the node configuration and cluster configuration use the same port value from the Terraform resource data. Previously, the node was hardcoded to use port 8443 while the cluster configuration used the configured apiserver_port value.

  • Extract the apiserver_port value into a variable for reuse
  • Update the node configuration to use the configured port instead of hardcoded 8443
  • Maintain consistency by using the same variable for both configurations

@scott-the-programmer scott-the-programmer enabled auto-merge (squash) July 29, 2025 12:42
Repository owner deleted a comment from coderabbitai bot Jul 29, 2025
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.88%. Comparing base (9095c3c) to head (c2e8cf6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   78.85%   78.88%   +0.03%     
==========================================
  Files          18       18              
  Lines        1305     1307       +2     
==========================================
+ Hits         1029     1031       +2     
  Misses        239      239              
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scott-the-programmer scott-the-programmer merged commit e0fcaed into main Jul 29, 2025
1 check passed
@scott-the-programmer scott-the-programmer deleted the bug/api-server-port branch July 29, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apiserver port is not applied
1 participant