Skip to content

Wrapper to assign futures to the correct event loop #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Jul 23, 2024

Closes #307

Tasks:

  • implementation (I'm working on a callback decorator instead)
  • tests
  • docs

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

❌ Patch coverage is 60.60606% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.21%. Comparing base (84ba393) to head (147db94).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
scrapy_playwright/utils.py 60.86% 9 Missing ⚠️
scrapy_playwright/_utils.py 62.50% 3 Missing ⚠️
scrapy_playwright/handler.py 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (84ba393) and HEAD (147db94). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (84ba393) HEAD (147db94)
6 3
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #308      +/-   ##
===========================================
- Coverage   100.00%   93.21%   -6.79%     
===========================================
  Files            6        7       +1     
  Lines          603      634      +31     
===========================================
- Hits           603      591      -12     
- Misses           0       43      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elacuesta
Copy link
Member Author

Fixed by #351, closing.

@elacuesta elacuesta closed this Aug 13, 2025
@elacuesta elacuesta deleted the ensure-future-threaded-loop branch August 13, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: cannot await coroutines when handling page in callback
1 participant