Added Comprehensive Cryptographic Tests #1712
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gap-editor
requested review from
Cashmaney,
toml01,
liorbond and
valdok
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Comprehensive Cryptographic Tests
This PR implements a complete suite of cryptographic tests for the Secret Network enclave's shared crypto module. We've addressed the TODO comment in the crypto library by adding proper encryption tests and other critical cryptographic function tests. The implementation includes AES-SIV encryption/decryption tests with both test vectors and roundtrip verification, ensuring that the encryption functionality works correctly with various inputs including empty additional authenticated data. We've also added SHA-256 hash tests with standard test vectors to verify the integrity of the hashing implementation. HMAC-SHA256 tests were implemented to confirm that the message authentication code functionality produces consistent results with the same inputs while properly differing when keys or messages change. Additionally, we've added Ed25519 digital signature tests that verify key generation, signing, and verification processes, including negative tests that ensure signature verification fails appropriately with modified messages or different keys. All tests are now registered in the main test runner and will execute when tests are run with the "test" feature enabled, providing comprehensive test coverage for the cryptographic foundations of the Secret Network.