move key instead of borrowing #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshelB
changed the base branch from
master
to
match-cw-storage-plus-map-support-borrowed-key
eshelB
added
the
match cw-storage-plus
This was referenced Feb 19, 2023
toml01
reviewed
Feb 23, 2023
| /// Our int keys are simply the big-endian representation bytes for unsigned ints, | ||
| /// but "sign-flipped" (xored msb) big-endian bytes for signed ints. | ||
| /// | ||
| /// So that the representation of signed integers is in the right lexicographical order. |
There was a problem hiding this comment.
That's a cool trick, but irrelevant for Secret (since we don't have iterators)
I wonder if that's needed
| assert_eq!(x.next().unwrap()?, key1); | ||
|
|
||
| assert_eq!(x.next().unwrap()?, key2); | ||
| // slice types convert to owned types when iterating over keys |
There was a problem hiding this comment.
That's because
pub trait KeyDeserialize {
type Output: ... + DeserializeOwned + ...;
...
}right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now you call
keymap.insert("key")instead ofkeymap.insert(&"key")