clover and clover-plus brightness rework #147
Open
+47
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
seems like cabc_on / cabc_off could be separate functions, cacbc_on being shared between 2 panels |
Author
|
Other panel drivers contain CABC-related logic both in init and off functions |
minlexx
reviewed
Nov 3, 2025
setotau
force-pushed
the
setotau/qcom-sdm660-6.18.y-clover-brightness-rework
branch
2 times, most recently
from
d07dca1 to
05156fc
Compare
NT51021-based panels support content-adaptive brightness control by generating a PWM signal for backlight driver IC. Content adaptation means that content grey level scale can be increased while simultaneously decreasing brightness of the backlight to achieve same perceived brightness. This makes the power consumption of backlight be reduced with keeping acceptable display quality. Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
The qcom-wled backlight controller supports CABC, so add a property, that enables this feature to qcom-wled node to follow-up added CABC support to the panel driver. Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
The LP8556 backlight controller also supports the CABC feature, so configure it to support this. Also remove a comment about EPROM start, and clarify some EPROM values' meaning. Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
setotau
force-pushed
the
setotau/qcom-sdm660-6.18.y-clover-brightness-rework
branch
from
05156fc to
128bc94
Compare
minlexx
approved these changes
Nov 3, 2025
Member
minlexx
left a comment
minlexx
left a comment
There was a problem hiding this comment.
Assuming you've tested that panel on clover/plus still works...
Author
|
Yes, it works fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both panels for xiaomi-clover and xiaomi-clover-plus support content-adaptive brightness control, so add needed programming sequences to enable this feature and configure backlight IC's for both devices to support this.