Skip to content
Draft
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-comics-add.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@segment/analytics-signals-runtime': minor
---

Update ProcessSignal type for experimental "constants" object
5 changes: 5 additions & 0 deletions .changeset/three-oranges-work.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@segment/analytics-signals': minor
---

Update iframe sandbox so CSP only requires :blob permission
17 changes: 15 additions & 2 deletions packages/signals/signals-example/src/lib/analytics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
// You only want to instantiate SignalsPlugin in a browser context, otherwise you'll get an error.

import { AnalyticsBrowser } from '@segment/analytics-next'
import { SignalsPlugin, ProcessSignal } from '@segment/analytics-signals'
import {
SignalsPlugin,
SignalsPluginSettingsConfig,
ProcessSignal,
} from '@segment/analytics-signals'

export const analytics = new AnalyticsBrowser()
if (!process.env.WRITEKEY) {
Expand All @@ -29,11 +33,20 @@ const processSignalExample: ProcessSignal = (
}
}

const getQueryParams = () => {
const params = new URLSearchParams()
const sandboxStrategy = params.get('sandboxStrategy')
return {
sandboxStrategy:
sandboxStrategy as SignalsPluginSettingsConfig['sandboxStrategy'],
}
}
const isStage = process.env.STAGE === 'true'

const queryParams = getQueryParams()
const signalsPlugin = new SignalsPlugin({
...(isStage ? { apiHost: 'signals.segment.build/v1' } : {}),
sandboxStrategy: 'global',
sandboxStrategy: queryParams.sandboxStrategy ?? 'iframe',
// processSignal: processSignalExample,
})

Expand Down
1 change: 0 additions & 1 deletion packages/signals/signals-runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"build:esm": "yarn tsc -p tsconfig.build.json",
"build:cjs": "yarn tsc -p tsconfig.build.json --outDir ./dist/cjs --module commonjs",
"build:global": "node build-signals-runtime-global.js",
"assert-generated": "bash scripts/assert-generated.sh",
"watch": "rm -rf dist/esm && yarn build:esm && yarn build:esm --watch",
"watch:test": "yarn test --watch",
"tsc": "yarn run -T tsc",
Expand Down
17 changes: 0 additions & 17 deletions packages/signals/signals-runtime/scripts/assert-generated.sh

This file was deleted.

6 changes: 2 additions & 4 deletions packages/signals/signals/.lintstagedrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
module.exports = {
...require("@internal/config").lintStagedConfig,
'src/lib/workerbox/*.{js,ts,html}': ['yarn workerbox']
}
module.exports = require("@internal/config").lintStagedConfig


2 changes: 0 additions & 2 deletions packages/signals/signals/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
"build:esm": "yarn tsc -p tsconfig.build.json",
"build:cjs": "yarn tsc -p tsconfig.build.json --outDir ./dist/cjs --module commonjs",
"build:bundle": "NODE_ENV=production yarn run webpack",
"workerbox": "node scripts/build-workerbox.js",
"assert-generated": "sh scripts/assert-workerbox-built.sh",
"watch": "rm -rf dist && yarn concurrently 'yarn build:bundle --watch' 'yarn build:esm --watch'",
"version": "sh scripts/version.sh",
"watch:test": "yarn test --watch",
Expand Down
16 changes: 0 additions & 16 deletions packages/signals/signals/scripts/assert-workerbox-built.sh

This file was deleted.

64 changes: 0 additions & 64 deletions packages/signals/signals/scripts/build-workerbox.js

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@
import {
normalizeEdgeFunctionURL,
GlobalScopeSandbox,
WorkerSandbox,
IframeSandboxSettings,
SignalSandbox,
NoopSandbox,
IframeSandbox,
} from '../../processor/sandbox'

export class SignalsEventProcessorSubscriber implements SignalsSubscriber {
Expand All @@ -36,11 +35,9 @@
sandboxSettings.processSignal
) {
logger.debug('Initializing sandbox: iframe')
sandbox = new WorkerSandbox(
new IframeSandboxSettings({
processSignal: sandboxSettings.processSignal,
edgeFnDownloadURL: normalizedEdgeFunctionURL,
})
sandbox = new IframeSandbox(

Check warning on line 38 in packages/signals/signals/src/core/middleware/event-processor/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/signals/signals/src/core/middleware/event-processor/index.ts#L38

Added line #L38 was not covered by tests
normalizedEdgeFunctionURL,
sandboxSettings.processSignal
)
} else {
logger.debug('Initializing sandbox: global scope')
Expand Down

This file was deleted.

16 changes: 0 additions & 16 deletions packages/signals/signals/src/core/processor/polyfills.ts

This file was deleted.

Loading