Skip to content

Expose BaseUserTraits #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 8, 2025
Merged

Expose BaseUserTraits #1306

merged 6 commits into from
Jul 8, 2025

Conversation

chenxzhang
Copy link
Contributor

@chenxzhang chenxzhang commented Jun 6, 2025

Per #1244, this PR exposes BaseUserTraits.

  • I've included a changeset (psst. run yarn changeset. Read about changesets here).

@chenxzhang chenxzhang requested a review from silesky June 6, 2025 18:51
Copy link

changeset-bot bot commented Jun 6, 2025

🦋 Changeset detected

Latest commit: a3c8b8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@segment/analytics-core Patch
@segment/analytics-next Patch
@segment/analytics-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.87%. Comparing base (c0d58e3) to head (a3c8b8f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1306   +/-   ##
=======================================
  Coverage   82.87%   82.87%           
=======================================
  Files         225      225           
  Lines        6019     6019           
  Branches     1365     1365           
=======================================
  Hits         4988     4988           
  Misses       1031     1031           
Flag Coverage Δ
browser 92.21% <ø> (ø)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

---
'@segment/analytics-core': patch
'@segment/analytics-next': patch
'@segment/analytics-node': patch
Copy link
Contributor

@silesky silesky Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The only package that you need to explicitly reference is core here, all dependent package will be bumped automatically by changesets. (cool, I know)

@chenxzhang chenxzhang requested a review from silesky June 17, 2025 17:10
@silesky silesky merged commit 5b6bdd9 into master Jul 8, 2025
7 checks passed
@silesky silesky deleted the LIB-2398/expose-base-trait branch July 8, 2025 17:19
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants