Skip to content

Update Node.js version to ^20 across the repository #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

neelkanth-kaushik
Copy link
Contributor

Update Node.js version to ^20 across repository

Changes done:

  • Updated GitHub Actions workflow to test against Node version ^20
    • modified: .github/workflows/ci.yml
    • modified: packages/node/package.json

Already present

  • .nvmrc was already set to use Node 20.9.0
  • engines.node was already set to use Node ^20 in root/package.json

Copy link

changeset-bot bot commented Jun 9, 2025

🦋 Changeset detected

Latest commit: 959310d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neelkanth-kaushik neelkanth-kaushik requested a review from silesky June 9, 2025 04:32
@neelkanth-kaushik neelkanth-kaushik self-assigned this Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.87%. Comparing base (c0d58e3) to head (959310d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1307   +/-   ##
=======================================
  Coverage   82.87%   82.87%           
=======================================
  Files         225      225           
  Lines        6019     6019           
  Branches     1365     1365           
=======================================
  Hits         4988     4988           
  Misses       1031     1031           
Flag Coverage Δ
browser 92.21% <ø> (ø)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -17,7 +17,7 @@
"!*.tsbuildinfo"
],
"engines": {
"node": ">=18"
"node": "^20"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want ">=", since this affects all consumers of this library (not just us!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then in the root package.json as well it should be ">=20" rather than "^20"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done it in both node/package.json and root package.json

silesky
silesky previously approved these changes Jun 9, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset for this change? Minor bump is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants