-
Notifications
You must be signed in to change notification settings - Fork 152
Update Node.js version to ^20 across the repository #1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 959310d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1307 +/- ##
=======================================
Coverage 82.87% 82.87%
=======================================
Files 225 225
Lines 6019 6019
Branches 1365 1365
=======================================
Hits 4988 4988
Misses 1031 1031
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
packages/node/package.json
Outdated
@@ -17,7 +17,7 @@ | |||
"!*.tsbuildinfo" | |||
], | |||
"engines": { | |||
"node": ">=18" | |||
"node": "^20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still want ">=", since this affects all consumers of this library (not just us!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then in the root package.json as well it should be ">=20" rather than "^20"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done it in both node/package.json and root package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a changeset for this change? Minor bump is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Update Node.js version to ^20 across repository
Changes done:
Already present