Keep worker threads running until exit #278
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our (@buildkite's) Datadog profiler reported numerous threads being spawned by this gem in one of our services. We tracked it down to this return statement which causes the worker thread to terminate whenever the queue is empty:
analytics-ruby/lib/segment/analytics/client.rb
Line 173 in 167f59f
This creates unnecessary thread churn in long-running applications. Instead of terminating when the queue is empty, the worker thread should remain alive and wait for new messages. The current behavior causes the thread to die and be replaced repeatedly - each time the queue empties and then receives new messages, a new thread must be spawned, which is inefficient, especially when analytics are emitted frequently.
This PR fixes the issue by replacing the early return with a sleep/continue pattern, keeping the worker thread alive during idle periods.