Skip to content

Conversation

alecbatch
Copy link

Proposed changes

Merge timing

Related issues (optional)

@alecbatch alecbatch requested a review from a team as a code owner June 12, 2025 14:40
@alecbatch alecbatch requested a review from sade-wusi June 12, 2025 14:40
@sade-wusi sade-wusi added the content-update updates to content that are not new features, includes grammar fixes, added notes label Jun 12, 2025
Copy link
Contributor

@sade-wusi sade-wusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor rewording and a question about whether page ID should be readded.

@@ -1,101 +1,21 @@
---
title: Batch Destination
id: 596d11f870a3e552b957e6d9
Copy link
Contributor

@sade-wusi sade-wusi Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alecbatch Was the page ID deliberately deleted?

@alecbatch
Copy link
Author

Hello @sade-wusi, thank you for your feedback. I took advantage of the completion of the connector to update the documentation (and add your corrections).

Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit ad71fb8
🔍 Latest deploy log https://app.netlify.com/projects/segment-docs/deploys/68ada10a97b8740008248761
😎 Deploy Preview https://deploy-preview-7677--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit b5cb924
🔍 Latest deploy log https://app.netlify.com/projects/segment-docs/deploys/68adaacbc98270000890ef5b
😎 Deploy Preview https://deploy-preview-7677--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@sade-wusi sade-wusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of wording changes to fit our style guide, otherwise it all looks great!

@alecbatch
Copy link
Author

alecbatch commented Aug 26, 2025

Great, thanks so much, @sade-wusi. What are the next steps for deploying the documentation in your Segment space?

@sade-wusi
Copy link
Contributor

@alecbatch I'll merge the pull request to be deployed later this week. We usually deploy all changes to our docs on a Thursday after 11am PT, with changes going live shortly afterwards.

@alecbatch
Copy link
Author

great, thanks for your (quick) answer!

@sade-wusi sade-wusi merged commit a4004b4 into segmentio:develop Aug 26, 2025
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants