-
Notifications
You must be signed in to change notification settings - Fork 380
Batch documentation #7677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch documentation #7677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor rewording and a question about whether page ID should be readded.
@@ -1,101 +1,21 @@ | |||
--- | |||
title: Batch Destination | |||
id: 596d11f870a3e552b957e6d9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alecbatch Was the page ID deliberately deleted?
04003c3
to
7537c86
Compare
Hello @sade-wusi, thank you for your feedback. I took advantage of the completion of the connector to update the documentation (and add your corrections). |
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a couple of wording changes to fit our style guide, otherwise it all looks great!
Great, thanks so much, @sade-wusi. What are the next steps for deploying the documentation in your Segment space? |
@alecbatch I'll merge the pull request to be deployed later this week. We usually deploy all changes to our docs on a Thursday after 11am PT, with changes going live shortly afterwards. |
great, thanks for your (quick) answer! |
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Merge timing
Related issues (optional)