Skip to content

[CLNP-6715]Added markAsUnread #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 30, 2025

Conversation

danney-chun
Copy link
Contributor

@danney-chun danney-chun commented Jun 26, 2025

[feat]: Added markAsUnread.

// PR description (Optional)
ChatSDK에 markAsUnread 기능이 추가 됨에 따라, Uikit에서도 해당 기능이 사용할 수 있게 반영 되었습니다.
UX Figma
Uikit Spec

Fixes CLNP-6715

// Changelogs (Recommended)

Changelogs

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can set up a CLA to allow for the contribution.

Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 4571015
🔍 Latest deploy log https://app.netlify.com/projects/sendbird-uikit-react/deploys/6889c8ea386131000809f669
😎 Deploy Preview https://deploy-preview-1347--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

## For Internal Contributors

* Follow the [Scaled Trunk-Based Development
workflow](https://trunkbaseddevelopment.com/)
* Branch naming format: `{type}/TICKET_ID/description`
  * Type: `feat` / `fix` / `chore` / `doc` / `release`
* Receive PR review approvals
* Rebase your branch with the main branch and wait for CI to pass
* Squash merge your commit
  * Use imperative language in the title and description
  * Follow the provided template for PR description and squashing

### Template
```
// PR title (Required)
[type]: A short description of the changes in imperative language.

// PR description (Optional)
Add a brief description of the changes in this PR. Bullet points are also fine.

// Footer (Recommended)
Fixes [<TICKET_ID>](https://sendbird.atlassian.net/browse/<TICKET_ID>)

// Changelogs (Recommended)
// Add (internal) at the end of each changelog if internal.
### Changelogs

// Co-authors
// Add this if you pair programmed or they made significant contributions to the ideas in the code and you want to thank them.
Co-authored-by: Name name@example.com, Name2 name@example.com

```

### Checklist

Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

- [ ] **All tests pass locally with my changes**
- [ ] **I have added tests that prove my fix is effective or that my
feature works**
- [ ] **Public components / utils / props are appropriately exported**
- [ ] I have added necessary documentation (if appropriate)


## External Contributions

This project is not yet set up to accept pull requests from external
contributors.

If you have a pull request that you believe should be accepted, please
contact
the Developer Relations team <developer-advocates@sendbird.com> with
details
and we'll evaluate if we can set up a
[CLA](https://en.wikipedia.org/wiki/Contributor_License_Agreement) to
allow for the contribution.
@danney-chun danney-chun requested review from chrisallo and bang9 July 10, 2025 07:43
@danney-chun danney-chun self-assigned this Jul 10, 2025
@danney-chun danney-chun reopened this Jul 10, 2025
@danney-chun danney-chun marked this pull request as draft July 17, 2025 16:44
@danney-chun danney-chun marked this pull request as ready for review July 18, 2025 03:45
Copy link
Collaborator

@chrisallo chrisallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 고생 많으셨습니다!

## For Internal Contributors

* Follow the [Scaled Trunk-Based Development
workflow](https://trunkbaseddevelopment.com/)
* Branch naming format: `{type}/TICKET_ID/description`
  * Type: `feat` / `fix` / `chore` / `doc` / `release`
* Receive PR review approvals
* Rebase your branch with the main branch and wait for CI to pass
* Squash merge your commit
  * Use imperative language in the title and description
  * Follow the provided template for PR description and squashing

### Template
```
// PR title (Required)
[type]: A short description of the changes in imperative language.

// PR description (Optional)
Add a brief description of the changes in this PR. Bullet points are also fine.

// Footer (Recommended)
Fixes [<TICKET_ID>](https://sendbird.atlassian.net/browse/<TICKET_ID>)

// Changelogs (Recommended)
// Add (internal) at the end of each changelog if internal.
### Changelogs

// Co-authors
// Add this if you pair programmed or they made significant contributions to the ideas in the code and you want to thank them.
Co-authored-by: Name name@example.com, Name2 name@example.com

```

### Checklist

Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

- [ ] **All tests pass locally with my changes**
- [ ] **I have added tests that prove my fix is effective or that my
feature works**
- [ ] **Public components / utils / props are appropriately exported**
- [ ] I have added necessary documentation (if appropriate)


## External Contributions

This project is not yet set up to accept pull requests from external
contributors.

If you have a pull request that you believe should be accepted, please
contact
the Developer Relations team <developer-advocates@sendbird.com> with
details
and we'll evaluate if we can set up a
[CLA](https://en.wikipedia.org/wiki/Contributor_License_Agreement) to
allow for the contribution.
@danney-chun danney-chun merged commit 64de427 into main Jul 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants