Fixed concurrency issue #607 #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ckadluba
commented
Mar 15, 2025
ckadluba
commented
- Bugfix AuditTo uses shared DB Connection #607: Do not reuse SqlCommand because apparently it is not threadsafe. Set connection on command leads to a exception in audit sink under heavy load.
- Fixed a glitch in solution file
- Updated copyright year
- Updated changelog
* Updated copyright year where applicable * Removed copyright header from internal classes
It showed perf test project in the samples folder for some reason.
Do not reuse SqlCommand because apparently it is not threadsafe. Set connection on command leads to a exception in audit sink under heavy load.
ckadluba
force-pushed
the
607-exception-auditto-shared-sqlconnection
branch
from
e0ef000 to
edaa008
Compare
Cannot remove IDisposable from MSSqlServerAuditSink class without bumping major version, so we leave it the same.
ckadluba
force-pushed
the
607-exception-auditto-shared-sqlconnection
branch
from
edaa008 to
e0cb12a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.