Skip to content

Conversation

ckadluba
Copy link
Member

Azure.Identity dependency was added as a workaround to fix security issue serilog-mssql#624 caused by SqlClient. Now SqlClient was updated to 6.1.1 which does not cause the issue anymore and Azure.Identity could be removed again.
After SqlClient update from 5.2.3 to 6.1.1 we move the sink to major version 9.
@ckadluba ckadluba added this pull request to the merge queue Aug 20, 2025
Merged via the queue into serilog-mssql:dev with commit 4db075a Aug 20, 2025
7 checks passed
@ckadluba ckadluba requested a review from Copilot August 20, 2025 21:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Serilog.Sinks.MSSqlServer package to version 9.0.0 with major dependency updates, particularly upgrading Microsoft.Data.SqlClient from 5.2.3 to 6.1.1 and removing the Azure.Identity workaround that was previously needed for issue #624.

  • Updated Microsoft.Data.SqlClient from 5.2.3 to 6.1.1 and removed Microsoft.Identity.Client dependency
  • Upgraded multiple development and testing dependencies including BenchmarkDotNet, FluentAssertions, Moq, and Serilog
  • Bumped the package version from 8.2.3 to 9.0.0 to reflect breaking changes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/Serilog.Sinks.MSSqlServer/Serilog.Sinks.MSSqlServer.csproj Updated version prefix to 9.0.0 and removed Microsoft.Identity.Client package reference
Directory.Packages.props Updated versions for SqlClient, testing frameworks, and other dependencies
CHANGES.md Added changelog entry documenting the major version update and dependency changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -2,7 +2,7 @@

<PropertyGroup>
<Description>A Serilog sink that writes events to Microsoft SQL Server and Azure SQL</Description>
<VersionPrefix>8.2.3</VersionPrefix>
<VersionPrefix>9.0.0</VersionPrefix>
<EnablePackageValidation>true</EnablePackageValidation>
<PackageValidationBaselineVersion>8.0.0</PackageValidationBaselineVersion>
Copy link
Preview

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PackageValidationBaselineVersion should be updated to reflect the new major version. Consider updating it to 9.0.0 to maintain consistency with the new VersionPrefix.

Suggested change
<PackageValidationBaselineVersion>8.0.0</PackageValidationBaselineVersion>
<PackageValidationBaselineVersion>9.0.0</PackageValidationBaselineVersion>

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant