Skip to content

Conversation

bakjos
Copy link
Contributor

@bakjos bakjos commented Feb 28, 2025

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

According to the Spec the URI of the Endpoint Configuration can be a template or an expression, when using expressions, the parsing is failing

{
          "title": "EndpointConfiguration",
          "type": "object",
          "unevaluatedProperties": false,
          "properties": {
            "uri": {
              "title": "EndpointUri",
              "description": "The endpoint's URI.",
              "oneOf": [
                {
                  "title": "LiteralEndpointURI",
                  "description": "The literal endpoint's URI.",
                  "$ref": "#/$defs/uriTemplate"
                },
                {
                  "title": "ExpressionEndpointURI",
                  "$ref": "#/$defs/runtimeExpression",
                  "description": "An expression based endpoint's URI."
                }
              ]
            },
            "authentication": {
              "$ref": "#/$defs/referenceableAuthenticationPolicy",
              "title": "EndpointAuthentication",
              "description": "The authentication policy to use."
            }
          },
          "required": [
            "uri"
          ]
        }

Special notes for reviewers:

Additional information (if needed):

@bakjos bakjos force-pushed the bakjos/expression_endpoint branch 2 times, most recently from acda9bd to 870dddb Compare February 28, 2025 21:00
@ricardozanini
Copy link
Member

I'll take a look on this, thanks for the PR!

@ricardozanini
Copy link
Member

@bakjos I've just merged the implementation PR, which I think addresses this issue. Do you mind rebasing it?

@ricardozanini
Copy link
Member

@bakjos, mind taking a look at the main if it's still a problem?

@bakjos bakjos force-pushed the bakjos/expression_endpoint branch from 870dddb to 46b0675 Compare May 2, 2025 13:04
@bakjos
Copy link
Contributor Author

bakjos commented May 2, 2025

@ricardozanini Sadly, it's still a problem. I have rebased it with main and pushed the changes again

@ricardozanini
Copy link
Member

@bakjos I'll take a look! Can you please sign your commit?

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please sign your commit so I can merge it!

Signed-off-by: Gio Gutierrez <giovanny.gutierrez@commure.com>
@bakjos bakjos force-pushed the bakjos/expression_endpoint branch from 46b0675 to 9c686e3 Compare May 2, 2025 14:32
@bakjos
Copy link
Contributor Author

bakjos commented May 2, 2025

@ricardozanini done

@ricardozanini
Copy link
Member

@bakjos I'll merge and do a minor release.

@ricardozanini ricardozanini merged commit edd5f5e into serverlessworkflow:main May 2, 2025
3 checks passed
@ricardozanini ricardozanini added bug 🐛 Something isn't working area:spec labels May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:spec bug 🐛 Something isn't working spec:1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants