Skip to content

Fix rake tasks after workspace structure merge (PR #1830) #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix rake tasks after workspace structure merge (PR #1830) #1839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34a9f97
Fix node_package rake task for workspace structure
ihabadham Sep 29, 2025
330ba11
Fix shakapacker_examples rake task issues
ihabadham Sep 29, 2025
9444768
Refactor: append --skip-javascript inline instead of mutating rails_o…
ihabadham Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rakelib/node_package.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace :node_package do

task :build do
puts "Building Node Package and running 'yalc publish'"
sh "yarn run build && yalc publish"
sh "yarn run build && yarn yalc publish"
end
end

Expand Down
5 changes: 2 additions & 3 deletions rakelib/shakapacker_examples.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,15 @@ namespace :shakapacker_examples do # rubocop:disable Metrics/BlockLength
task example_type.gen_task_name_short => example_type.clobber_task_name do
puts "Running shakapacker_examples:#{example_type.gen_task_name_short}"
mkdir_p(example_type.dir)
example_type.rails_options += "--skip-javascript"
sh_in_dir(examples_dir, "rails new #{example_type.name} #{example_type.rails_options}")
sh_in_dir(examples_dir, "rails new #{example_type.name} #{example_type.rails_options} --skip-javascript")
sh_in_dir(example_type.dir, "touch .gitignore")
sh_in_dir(example_type.dir,
"echo \"gem 'react_on_rails', path: '#{relative_gem_root}'\" >> #{example_type.gemfile}")
sh_in_dir(example_type.dir, "echo \"gem 'shakapacker', '>= 8.2.0'\" >> #{example_type.gemfile}")
bundle_install_in(example_type.dir)
sh_in_dir(example_type.dir, "rake shakapacker:install")
sh_in_dir(example_type.dir, example_type.generator_shell_commands)
sh_in_dir(example_type.dir, "yarn")
sh_in_dir(example_type.dir, "npm install")
end
end

Expand Down
Loading