feat(api,ssh,pkg): standardize errors and logs on internal http client #5274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybarreto
force-pushed
the
feat/improve-http-internal-client
branch
2 times, most recently
from
127055d to
5e2ed68
Compare
henrybarreto
force-pushed
the
feat/improve-http-internal-client
branch
8 times, most recently
from
1ddeaeb to
8bfb920
Compare
It refactors the internal client to standardize error handling and improve its structure. A new error type is introduced to encapsulate HTTP response details, including the status code, which was previously returned as a separate value. This simplifies the client's function signatures and makes error handling more consistent. The configuration has been extracted into a dedicated file with default values, and the now-redundant WithConfig option has been removed. All client methods have been updated to use the new error handling and configuration, and the corresponding mocks and usages have been adjusted accordingly.
otavio
previously approved these changes
Sep 29, 2025
henrybarreto
force-pushed
the
feat/improve-http-internal-client
branch
from
8bfb920 to
ef115f0
Compare
otavio
previously approved these changes
Sep 29, 2025
henrybarreto
force-pushed
the
feat/improve-http-internal-client
branch
from
197ad39 to
ef115f0
Compare
otavio
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.