User interface implementation #127

dkocher · 2025-06-13T13:51:23Z

Resolve #87.

macOS
Windows

Depends on

UVF Add implementation of unified vault format (UVF). iterate-ch/cyberduck#17559
Alert Refactoring Refactor alerts to allow display as sheet or modal. iterate-ch/cyberduck#17154
Refactor features to always allow proxying by path parameter iterate-ch/cyberduck#17534

dkocher · 2025-06-16T20:17:50Z

First Login

Authorization Required

pom.xml

This reverts commit 87452aa

…guration instead.

…sion without factory.

chenkins · 2025-10-21T17:19:47Z

hub/src/main/java/cloud/katta/workflows/UserKeysServiceImpl.java

-                        return this.recover(me, deviceKeyPair, prompt.askForAccountKeyAndDeviceName(hub, COMPUTER_NAME));
+                        final AccountKeyAndDeviceName input = prompt.askForAccountKeyAndDeviceName(hub, COMPUTER_NAME);
+                        if(input.addToKeychain()) {
+                            this.save(hub, me, input.accountKey());


Account Key must not be saved to keychain as per https://github.com/shift7-ch/katta-arc42/pull/1/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R333-R336. The account key can be changed in the web UI and therefore this can lead to inconsistencies.

chenkins · 2025-10-21T17:20:07Z

hub/src/main/java/cloud/katta/workflows/UserKeysServiceImpl.java

-
-            return this.uploadDeviceKeys(deviceName,
+            if(input.addToKeychain()) {
+                this.save(hub, me, accountKey);


chenkins · 2025-10-21T17:23:54Z

hub/src/test/java/cloud/katta/workflows/AbstractHubWorkflowTest.java

-            // upload template (STS: create bucket first, static: existing bucket)
-            // TODO test with multiple wot levels?
+            final UUID vaultId = UUID.fromString(new UUIDRandomStringService().random());
+            final Path bucket = new Path(null == config.vault.bucketName ? null == storageProfileWrapper.getBucketPrefix() ? "katta-test-" + vaultId : storageProfileWrapper.getBucketPrefix() + vaultId : config.vault.bucketName,


Double ? is not readable imho.

chenkins · 2025-10-22T06:04:49Z

hub/src/main/java/cloud/katta/core/DefaultDeviceSetupCallback.java

+                    new StringAppender()
+                            .append(LocaleFactory.localizedString("On first login, every user gets a unique Account Key", "Hub"))
+                            .append(LocaleFactory.localizedString("Your Account Key is required to login from other apps or browsers", "Hub"))
+                            .append(LocaleFactory.localizedString("You can see a list of authorized apps on your profile page", "Hub")).toString(),


Is it clear for Desktop users where to find profile page?

chenkins · 2025-10-22T06:05:47Z

hub/src/main/java/cloud/katta/core/DefaultDeviceSetupCallback.java

+                    LocaleFactory.localizedString("Authorization Required", "Hub"),
+                    new StringAppender()
+                            .append(LocaleFactory.localizedString("This is your first login on this device.", "Hub"))
+                            .append(LocaleFactory.localizedString("Your Account Key is required to link this browser to your account.", "Hub")).toString(),


this browser?

chenkins · 2025-10-22T06:19:06Z

hub/src/main/java/cloud/katta/protocols/hub/HubStorageLocationService.java

+                            .enabled(true)
+                            .maxWotDepth(null));


Take from configurable defaults for enabled and maxWotDepth.

chenkins · 2025-10-22T06:21:04Z

hub/src/main/java/cloud/katta/protocols/hub/HubUVFVault.java

+                    storage.getHost().getProtocol().isRoleConfigurable() && !S3Session.isAwsHostname(storage.getHost().getHostname()),
+                    storage.getHost().getProtocol().isRoleConfigurable() && S3Session.isAwsHostname(storage.getHost().getHostname()));


Give name, extract to variable each.

chenkins · 2025-10-22T06:22:59Z

hub/src/main/java/cloud/katta/protocols/hub/HubUVFVault.java

+            configuration.setProperty(S3AssumeRoleProtocol.S3_ASSUMEROLE_ROLEARN_TAG, null);
+            storage.open(ProxyFactory.get(), new DisabledHostKeyCallback(), login, new DisabledCancelCallback());
+            final Path vault;
+            if(false) {


Implementation is expected to be in super class with generic implementation for UVF. @ylangisc

chenkins · 2025-10-22T06:24:38Z

...src/main/java/cloud/katta/protocols/hub/serializer/StorageProfileDtoWrapperDeserializer.java

                        properties.add(String.format("%s=%s", S3AssumeRoleProtocol.S3_ASSUMEROLE_DURATIONSECONDS, dto.getStsDurationSeconds().toString()));
                    }
                }
+                properties.add("s3.assumerole.rolearn.tag.vaultid.key=Vault");


Extract key to constant?

chenkins · 2025-10-22T06:26:48Z

...src/main/java/cloud/katta/protocols/hub/serializer/StorageProfileDtoWrapperDeserializer.java

+            case ROLE_KEY_CONFIGURABLE_KEY:
+                return dto.getStsRoleArn() != null;


Add comment on re-using `ROLE_KEY_CONFIGURABLE_KEY? for STS/static distinction, hard to remember.

dkocher added this to the 1.0.0 milestone Jun 13, 2025

dkocher requested a review from chenkins June 13, 2025 13:51

dkocher self-assigned this Jun 13, 2025

dkocher force-pushed the issues/87-macos branch 2 times, most recently from c905afa to 0f41060 Compare June 14, 2025 08:20

dkocher force-pushed the issues/87-macos branch 2 times, most recently from 22be0cf to 75af26c Compare June 17, 2025 11:02

chenkins marked this pull request as draft June 17, 2025 11:20

chenkins changed the title ~~[WiP] User interface implementation~~ User interface implementation Jun 17, 2025

chenkins reviewed Jun 17, 2025

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

dkocher force-pushed the issues/87-macos branch from d061286 to f27863b Compare June 26, 2025 14:05

dkocher force-pushed the issues/87-macos branch from f30af43 to 38e9aca Compare July 5, 2025 06:22

dkocher marked this pull request as ready for review July 5, 2025 06:23

dkocher force-pushed the issues/87-macos branch from 38e9aca to 5f6712b Compare July 9, 2025 12:23

dkocher force-pushed the issues/87-macos branch from 5f6712b to a18c380 Compare July 23, 2025 09:15

dkocher force-pushed the issues/87-macos branch from a18c380 to 3d24571 Compare August 12, 2025 08:20

dkocher force-pushed the issues/87-macos branch 2 times, most recently from f10ac31 to d3d34d4 Compare September 4, 2025 19:21

dkocher force-pushed the issues/87-macos branch 2 times, most recently from 88dbfaa to 94a4d11 Compare October 14, 2025 13:38

dkocher linked an issue Oct 15, 2025 that may be closed by this pull request

Allow to create new vault #83

Open

1 task

dkocher force-pushed the issues/87-macos branch 3 times, most recently from 6031d93 to d28bcfd Compare October 15, 2025 15:31

dkocher marked this pull request as draft October 15, 2025 15:31

dkocher force-pushed the issues/87-macos branch 4 times, most recently from 809159a to 8650abd Compare October 16, 2025 11:45

dkocher added 28 commits October 21, 2025 19:41

Delete test.

0dae67f

Revert "No preloading of buckets."

a5cd29b

This reverts commit 87452aa

Ensure listener notification.

aeef089

Ignore vaults that fail to load.

5ae6d55

Delete unused accessor.

91e6bcc

Keep user keys alive.

682d812

Make user keys short-lived.

98c3095

Inline configuration.

2e36d89

Inline configuration.

717850d

Wrap with expiring holders.

3108aac

Obtain hub session as feature.

6526cf8

Logging.

f13cc40

Adopt interface changes.

1d2801d

Merge implementations.

19a5005

Share OAuth tokens. Resolves #29.

833f56b

Read cached setting.

f0cbfce

Extract field.

e098e7c

Isolate storage configurations per hub.

67d76ff

Extract builder method.

d07f6b4

Delete unused.

448b3d6

Remove duplicate field.

548ee66

Remove redundant constructor.

a76a555

Use service loader.

a696a75

Fail on missing configuration.

746b1cb

Move to class.

7bef746

Move to class.

16e832b

Remove profile properties to be configured from storage profile confi…

b03cde1

…guration instead.

Inject reference to Hub connection/Oauth explicitly. Load storage ses…

8bed1ae

…sion without factory.

dkocher force-pushed the issues/87-macos branch from fdee575 to 8bed1ae Compare October 21, 2025 17:42

chenkins requested changes Oct 22, 2025

View reviewed changes

		storage.getHost().getProtocol().isRoleConfigurable() && !S3Session.isAwsHostname(storage.getHost().getHostname()),
		storage.getHost().getProtocol().isRoleConfigurable() && S3Session.isAwsHostname(storage.getHost().getHostname()));

		case ROLE_KEY_CONFIGURABLE_KEY:
		return dto.getStsRoleArn() != null;

User interface implementation #127

Are you sure you want to change the base?

User interface implementation #127

Conversation

dkocher commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkocher commented Jun 16, 2025

First Login

Authorization Required

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dkocher commented Jun 13, 2025 •

edited

Loading