fix firebase get method not returning its promise #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Oct 7, 2019
|
@siddharthkp can we merge this? |
XhmikosR
reviewed
Dec 25, 2019
|
Ping @siddharthkp, can we get this in? |
|
Any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #308, #224
Description
Currently, the
/valuesendpoint throws 500 error while fetching master stats.Apparently, this commit 9e4880b#diff-3f22b50a5bc8fc66727cf2798b216054L34
broke the functionality long time ago.
After fixing 1, I found that the global message was still not reflecting the changes in bundle sizes, showing
-null. I found that in https://github.com/siddharthkp/bundlesize/blob/master/src/reporter.js#L77, we access the file directly, which fails when the user provides a glob file in case they have a hash appended to their chunks.Types of changes