feat: add full disk volumes #12104
feat: add full disk volumes #12104
Conversation
shanduur
force-pushed
the
lvm-volumes
branch
2 times, most recently
from
7681083 to
6cf202a
Compare
shanduur
force-pushed
the
lvm-volumes
branch
17 times, most recently
from
b928782 to
7dc9ae9
Compare
| } | ||
|
|
||
| v.TypedSpec().Type = block.VolumeTypeDisk | ||
| v.TypedSpec().Locator.Match = labelVolumeMatch(volumeID) |
There was a problem hiding this comment.
I think this is unused/should be dropped? as it's a disk, we can't match on label
There was a problem hiding this comment.
We need some kind of matcher, but I think we can reuse disk locator here? This should be sufficient.
There was a problem hiding this comment.
I'm not sure, a good way is to reboot Talos and see what it does?
There was a problem hiding this comment.
I haven't seen any issues, however it goes through the provisioning flow each time - reusing disk locator should cut that, right?
There was a problem hiding this comment.
| } | ||
|
|
||
| v.TypedSpec().Type = block.VolumeTypeDisk | ||
| v.TypedSpec().Locator.Match = diskSelector |
There was a problem hiding this comment.
this does work, but by chance a bit (with a specific form of disk selector).
we have a problem here, the disk selector is evaluated in:
while volume locator in:
So anything which does simple disk.<something> works as they both have same.
But e.g. system_disk is not available in volume locator, also volume locator runs for partitions as well, so it might match it by accident.
So I think we need a separate locator.DiskMatch or something close to that for disk volumes.
Open to any other ideas as well
There was a problem hiding this comment.
Let me know if the changes I did make any sense. I've added different *cel.Env that is selected based on volume type: https://github.com/siderolabs/talos/pull/12104/files#diff-29f79fc583c81df9b1167eb597fb3642587aa952b153ee5c3c5190005577bd6bR54-R61
shanduur
force-pushed
the
lvm-volumes
branch
4 times, most recently
from
9c43c0f to
23a86c2
Compare
Orzelius
left a comment
Orzelius
left a comment
There was a problem hiding this comment.
Very cool
Love the thorough tests!
When set to `disk`, a full block device is used for the volume. When `volumeType = "disk"`: - Size specific settings are not allowed in the provisioning block (`minSize`, `maxSize`, `grow`). Signed-off-by: Mateusz Urbanek <mateusz.urbanek@siderolabs.com>
shanduur
force-pushed
the
lvm-volumes
branch
from
23a86c2 to
2059374
Compare
4 participants
volumeTypein UserVolumeConfig can be set todisk.When set to
disk, a full block device is used for the volume.When
volumeType = "disk":minSize,maxSize,grow).