-
Notifications
You must be signed in to change notification settings - Fork 23
chore: switch to unstable lighthouse and update dependencies #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
Do we need to keep the |
I'm wondering what we would do when merging Anchor to stable. We can't just change LH to stable, as there's no guarantee it's gonna work. So, should we use LH stable all the time? |
right now it is just around for reference, or if someone wants to compile a version without |
Right now, we can't use stable. IMO there is no special step to be taken when we merge to stable, as we want to use the same version as during development to ensure compatibility |
But seems reasonable that we should use stable LH in general, right? It's just another dependency as any other, perhaps even more important. So we shouldn't be using an unreleased, in-development version of it, should we? |
Lighthouse is primarily an application. Releases in their sense do not really apply to internal crates (also w.r.t. compatibility and testing). In other words, they test lighthouse as a full application, and |
# Conflicts: # Cargo.lock
This pull request has merge conflicts. Could you please resolve them @dknopik? 🙏 |
# Conflicts: # Cargo.lock
Proposed Changes
Everything we had in our Lighthouse
anchor
branch is finally merged into theirunstable
🥳Switch to specifying
branch = "unstable"
on our lighthouse dependencies. Note that the specific commit is still pinned byCargo.lock
, so it will not ever spontaneously break (but might ifcargo update
is called).Also, update all our dependencies.
Additional Info
Intentionally targets
unstable
to avoid risking some bug.This breaks the
blsful
feature onbls_lagrange
due to an accidental breaking change on a transitive dependency. Hopefully this is fixed upstream soon, but I am willing to accept this right now as we do not use that anyway.