Skip to content

Conversation

dknopik
Copy link
Member

@dknopik dknopik commented Sep 11, 2025

Proposed Changes

Everything we had in our Lighthouse anchor branch is finally merged into their unstable 🥳

Switch to specifying branch = "unstable" on our lighthouse dependencies. Note that the specific commit is still pinned by Cargo.lock, so it will not ever spontaneously break (but might if cargo update is called).

Also, update all our dependencies.

Additional Info

Intentionally targets unstable to avoid risking some bug.

This breaks the blsful feature on bls_lagrange due to an accidental breaking change on a transitive dependency. Hopefully this is fixed upstream soon, but I am willing to accept this right now as we do not use that anyway.

@dknopik dknopik added ready-for-review This PR is ready to be reviewed chore labels Sep 11, 2025
@Zacholme7
Copy link
Member

Do we need to keep the blsful related code if it is not used? Or is it planned to be used in the future

@diegomrsantos
Copy link
Contributor

I'm wondering what we would do when merging Anchor to stable. We can't just change LH to stable, as there's no guarantee it's gonna work. So, should we use LH stable all the time?

@dknopik
Copy link
Member Author

dknopik commented Sep 11, 2025

Do we need to keep the blsful related code if it is not used? Or is it planned to be used in the future

right now it is just around for reference, or if someone wants to compile a version without unsafe, but IMO it can be removed.

@dknopik
Copy link
Member Author

dknopik commented Sep 11, 2025

I'm wondering what we would do when merging Anchor to stable. We can't just change LH to stable, as there's no guarantee it's gonna work. So, should we use LH stable all the time?

Right now, we can't use stable. IMO there is no special step to be taken when we merge to stable, as we want to use the same version as during development to ensure compatibility

@diegomrsantos
Copy link
Contributor

I'm wondering what we would do when merging Anchor to stable. We can't just change LH to stable, as there's no guarantee it's gonna work. So, should we use LH stable all the time?

Right now, we can't use stable. IMO there is no special step to be taken when we merge to stable, as we want to use the same version as during development to ensure compatibility

But seems reasonable that we should use stable LH in general, right? It's just another dependency as any other, perhaps even more important. So we shouldn't be using an unreleased, in-development version of it, should we?

@dknopik
Copy link
Member Author

dknopik commented Sep 12, 2025

But seems reasonable that we should use stable LH in general, right? It's just another dependency as any other, perhaps even more important. So we shouldn't be using an unreleased, in-development version of it, should we?

Lighthouse is primarily an application. Releases in their sense do not really apply to internal crates (also w.r.t. compatibility and testing). In other words, they test lighthouse as a full application, and stable refers to that. Therefore I am not too bothered with using unstable, especially if it contains features we require, as we do right now and might in the future. That being said, it seems reasonable to switch to "stable" once that has all the things we need, but would not make it policy that it HAS to be stable.

Copy link

mergify bot commented Sep 22, 2025

This pull request has merge conflicts. Could you please resolve them @dknopik? 🙏

@mergify mergify bot added waiting-on-author and removed ready-for-review This PR is ready to be reviewed labels Sep 22, 2025
@mergify mergify bot added ready-for-review This PR is ready to be reviewed and removed waiting-on-author labels Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ready-for-review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants