Skip to content

Release - key management API #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 22, 2025
Merged

Release - key management API #108

merged 11 commits into from
Apr 22, 2025

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Apr 21, 2025

IDP-1514 add api-key endpoints to serverless-mfa-api-go

Added

  • Added two new endpoints: POST /api-key and POST /api-key/activate
  • Added storage middleware to save an initialized storage client in the request context. (Side note: dependency injection is a better solution, but I decided to continue with the existing paradigm for now.)

Changed

  • Change the Storage Load function to fail when no record is found. The only place this broke existing code was in BeginRegistration, but was easily fixed.
  • Renamed testutils.go to utils_test.go to hide test code from the app build.

@briskt briskt requested review from a team as code owners April 21, 2025 13:29
@briskt briskt requested review from ethancanne, jason-jackson and hobbitronics and removed request for a team April 21, 2025 13:29
mtompset
mtompset reviewed Apr 21, 2025
View reviewed changes
@mtompset
Copy link

The SonarQube issues aren't bad suggestions. Perhaps address them in a "clean up tests" PR later?

mtompset
mtompset approved these changes Apr 21, 2025
View reviewed changes
Copy link

@mtompset mtompset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The long functions were a blur, but I'm hoping your added tests covered those.

jason-jackson
jason-jackson approved these changes Apr 22, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt briskt merged commit 5c4f9a6 into main Apr 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtompset mtompset mtompset approved these changes

@jason-jackson jason-jackson jason-jackson approved these changes

@ethancanne ethancanne Awaiting requested review from ethancanne ethancanne is a code owner automatically assigned from silinternational/go-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/go-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @mtompset @jason-jackson