Skip to content

use AWS CDK for deployment #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

use AWS CDK for deployment #123

merged 3 commits into from
May 20, 2025

Conversation

briskt
Copy link
Contributor

@briskt briskt commented May 19, 2025

IDP-1529 Convert serverless-mfa-api-go to AWS CDK

Added

  • Added CDK to eventually replace the Serverless Framework. Once all production IdPs have been converted to use the new deployment, the Serverless-deployed resources and configuration can be removed.

Changed

  • Moved the app build command from the deploy.sh script to the workflow file.

@briskt briskt requested review from a team as code owners May 19, 2025 10:00
@briskt briskt requested review from ethancanne, jason-jackson and hobbitronics and removed request for a team May 19, 2025 10:00
forevermatt
forevermatt reviewed May 19, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

forevermatt
forevermatt approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel qualified to really review the Go code itself, but this looks fine as far as I understand it

@briskt briskt merged commit ca6e5d6 into main May 20, 2025
6 checks passed
@briskt briskt deleted the feature/cdk branch May 20, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt approved these changes

@ethancanne ethancanne Awaiting requested review from ethancanne ethancanne is a code owner automatically assigned from silinternational/go-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/go-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/go-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @forevermatt