Skip to content

Release 2.5.0 -- rotate an API key #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2025
Merged

Release 2.5.0 -- rotate an API key #125

merged 3 commits into from
May 30, 2025

Conversation

briskt
Copy link
Contributor

@briskt briskt commented May 28, 2025 •
edited
Loading

IDP-1089 serverless-mfa-api #6: Enable changing the API Secret in case it is compromised

Added

  • Added a new endpoint to rotate an API key by re-encrypting all related data.

@briskt briskt requested review from a team as code owners May 28, 2025 14:17
@briskt briskt requested review from ethancanne, jason-jackson and hobbitronics and removed request for a team May 28, 2025 14:17
hobbitronics
hobbitronics reviewed May 30, 2025
View reviewed changes
hobbitronics
hobbitronics reviewed May 30, 2025
View reviewed changes
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. Maybe use %w unless no error unwrapping will be done. If Sonar doesn't care about unused debugging function then I don't.

hobbitronics
hobbitronics approved these changes May 30, 2025
View reviewed changes
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. Maybe use %w unless no error unwrapping will be done. If Sonar doesn't care about unused debugging function then I don't.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt briskt changed the title new endpoint to rotate an API key by re-encrypting all related data Release 2.5.0 -- new endpoint to rotate an API key by re-encrypting all related data May 30, 2025
@briskt briskt changed the title Release 2.5.0 -- new endpoint to rotate an API key by re-encrypting all related data Release 2.5.0 -- rotate an API key May 30, 2025
@briskt briskt merged commit 6d90173 into main May 30, 2025
6 checks passed
@briskt briskt deleted the feature/key-rotate branch May 30, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@ethancanne ethancanne Awaiting requested review from ethancanne ethancanne is a code owner automatically assigned from silinternational/go-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/go-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics