Add EmbedContext argument in buildWidgetSpan #2615
Open
+10
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EchoEllet
reviewed
Jul 22, 2025
| @@ -11,7 +11,7 @@ abstract class EmbedBuilder { | |||
| String get key; | |||
| bool get expanded => true; | |||
|
|
|||
| WidgetSpan buildWidgetSpan(Widget widget) { | |||
| WidgetSpan buildWidgetSpan(Widget widget, EmbedContext embedContext) { | |||
There was a problem hiding this comment.
This is a breaking change. Clients need to update their code to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds EmbedContext as argument to buildWidgetSpan
Related Issues
Related #2614
Type of Change