add new DPoPTokenSerializer class for [de]serializing DPoPToken #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snarfed
force-pushed
the
dpop-token-serializer
branch
from
0d3c242 to
0ca1b1e
Compare
snarfed
changed the base branch from
authorization-request-serializer-dpop-key
to
main
Owner
Author
|
Moved to guillp#174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for guillp#122
@guillp one note here: this duplicates the existing code in AuthorizationRequestSerializer for [de]serializing DPoPKey. would you want a new DPoPKeySerializer class for that? I wasn't sure if you'd care more about the code duplication or the serializer class sprawl. I'm ok either way.