Skip to content

[WIP] facts.inventory: add DNS search domain to all DHCP pools #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kylerisse
Copy link
Member

@kylerisse kylerisse commented Mar 8, 2025

Description of PR

Adds DNS search domain to all DHCP pools.

Tests

  1. > nix build .#scaleInventory
  2. Reviewed output of DHCP checking v4 pool
{
        "subnet": "10.128.10.0/24",
        "id": 10128100,
        "user-context": {
          "vlan": "cfInstl"
        },
        "pools": [
          {
            "pool": "10.128.10.80 - 10.128.10.254"
          }
        ],
        "option-data": [
          {
            "name": "routers",
            "data": "10.128.10.1"
          },
          {
            "name": "domain-search",
            "data": "scale.lan"
          }
        ]
      }
  1. Reviewed output of DHCP checking v6 pool
{
        "subnet": "2001:470:f026:507::/64",
        "id": 25863,
        "user-context": {
          "vlan": "cfSigns"
        },
        "pools": [
          {
            "pool": "2001:470:f026:507:d8c::1 - 2001:470:f026:507:d8c::800"
          }
        ],
        "option-data": [
          {
            "name": "domain-search",
            "data": "scale.lan"
          }
        ]
      },
  1. > nix build .#checks.x86_64-linux.core

@kylerisse kylerisse changed the title [WIP] facts.inventory: add DNS search domain to all DHCP pools [REVIEW] facts.inventory: add DNS search domain to all DHCP pools Mar 8, 2025
@kylerisse kylerisse changed the title [REVIEW] facts.inventory: add DNS search domain to all DHCP pools [RREADY] facts.inventory: add DNS search domain to all DHCP pools Mar 8, 2025
@kylerisse kylerisse changed the title [RREADY] facts.inventory: add DNS search domain to all DHCP pools [READY] facts.inventory: add DNS search domain to all DHCP pools Mar 8, 2025
@kylerisse kylerisse changed the title [READY] facts.inventory: add DNS search domain to all DHCP pools [WIP] facts.inventory: add DNS search domain to all DHCP pools Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant