-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add CI for unused dependencies #3372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
latekvo
wants to merge
27
commits into
main
Choose a base branch
from
@latekvo/clean-project-packages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this workflow removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessary packages.
This PR reduces average yarn install time by
__%
(___ms
)Explanations:
--ignores="eslint-plugin-prettier"
-eslint-plugin-prettier
is unused, but required by the CIs.--ignores="expo-font"
- Used insideapp.config.js
, required by@swmansion/icons
.--skip-missing
- False hits. Real problematic missing packages will be caught by metro.--quiet
- No output on success, simplifies creating CIs.Note: all e2e tests seem to be broken
Size differences
with these changes:
example
-46,008
packages at565MB
root
-84,891
packages at1.3GB
without these changes (main):
example
-59,275
packages at689MB
root
-__,___
packages at1.3GB
Test plan
Command for
gesture-handler/
:depcheck --quiet --skip-missing --ignores="eslint-plugin-prettier"
Command for
gesture-handler/example/
:depcheck --quiet --ignores="eslint-plugin-prettier,expo-font"
all CIs are passing
open every example app, on all platforms and architectures available for given example app
prettier still works as intended