[LA] Don't clone props when not necessary #7772
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Jul 10, 2025
| x = newStyle.getProperty(runtime, "originX").asNumber(); | ||
| count++; | ||
| } | ||
| if (newStyle.hasProperty(runtime, "originY")) { |
There was a problem hiding this comment.
We should add early returns or use else if instead. Once this is done, we can just a boolean to store the information whether there is some custom style or not.
Suggested change
| if (newStyle.hasProperty(runtime, "originY")) { | |
| else if (newStyle.hasProperty(runtime, "originY")) { |
There was a problem hiding this comment.
We can't, the purpose of this class is to aggregate non-props updates in layout animations. We need to parse all of them, and we need to count them all, so that we can calculate how many props updates are there in a given layout animation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan