-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: 3D and 2D CSS transform matrix integration #8195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MatiPl01
wants to merge
30
commits into
main
Choose a base branch
from
@matipl01/combining-2d-and-3d-transforms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7072987
to
67247e8
Compare
f690fb3
to
1eac7a6
Compare
a7dab24
to
d1e5abf
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
## Summary This PR contains some code extracted from the #8195 that can be added separately in order not to add too much complexity to the already large PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR finally adds the integration of 2D and 3D transform matrix in transforms interpolation. The 2D matrix is used when possible to optimize interpolation. If the user uses a transformation that requires a 3D space (like x, y rotation or perspective), the 3D matrix is used instead. 2D transform matrix is automatically converted to the 3D transform matrix when needed.
Test plan
Code snippet