chore(Worklets): fix PlatformChecker init #8300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
piaskowyk
approved these changes
Sep 30, 2025
tjzel
added a commit
that referenced
this pull request
Oct 9, 2025
## Summary Fixes #8285. When initializing "PlatformChecker" in lazy import environments `globalThis.__RUNTIME_KIND` will be executed before it's defined in `runtimeKind` file. By changing it to function invocation we enforce that it's properly initialized. Also setting serialized values manually for `runOnUI` and `runOnUIAsync` has to be done only when not in web implementation. ## Test plan See fixed issue.
tjzel
added a commit
that referenced
this pull request
Oct 9, 2025
## Summary Fixes #8285. When initializing "PlatformChecker" in lazy import environments `globalThis.__RUNTIME_KIND` will be executed before it's defined in `runtimeKind` file. By changing it to function invocation we enforce that it's properly initialized. Also setting serialized values manually for `runOnUI` and `runOnUIAsync` has to be done only when not in web implementation. ## Test plan See fixed issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8285.
When initializing "PlatformChecker" in lazy import environments
globalThis.__RUNTIME_KINDwill be executed before it's defined inruntimeKindfile. By changing it to function invocation we enforce that it's properly initialized.Also setting serialized values manually for
runOnUIandrunOnUIAsynchas to be done only when not in web implementation.Test plan
See fixed issue.