feat(iOS): Bring back fullScreenSwipeEnabled prop #3242
Conversation
guides/GUIDE_FOR_LIBRARY_AUTHORS.md
Outdated
| For iOS prior to 26, swiping with this option results in the same transition animation as `simple_push` by default. | ||
| It can be changed to other custom animations with `customAnimationOnSwipe` prop, but default iOS swipe animation | ||
| is not achievable due to usage of custom recognizer. | ||
|
|
||
| For iOS 26 and up, native `interactiveContentPopGestureRecognizer` is used, and this prop controls whether it should | ||
| be enabled or not. |
There was a problem hiding this comment.
I get impression from this description that customAnimationOnSwipe does not work anymore on iOS 26 & I remember from testing that was not the case, was it?
If it still works, we should rephrase the description so that it indicates that customAnimationOnSwipe is possible in both cases but it results in new native gesture recognizer not being used.
ios/RNSScreen.h
Outdated
| /** | ||
| * Returns a boolean equivalent of fullScreenSwipeEnabled OptionalBoolean, resolves Undefined as `false` for iOS < 26, | ||
| * `true` otherwise. | ||
| */ | ||
| - (BOOL)fullScreenSwipeEnabledBoolean; |
There was a problem hiding this comment.
I don't like this approach here. Please take a look how obscureBackground, which also uses RNSOptionalBoolean is implemented & follow that pattern.
There was a problem hiding this comment.
This is somewhat different, because the value is used in RNSScreenStack, and for obscureBackground there is no usages outside of the context it's declared in. Could you point me in some direction here?
There was a problem hiding this comment.
Yep, I could see fullScreenSwipeEnabled property being readonly, overwrite the getter to return appropriate BOOL value & we do not need any additional method here.
There was a problem hiding this comment.
The backing field can be of RNSOptionalBoolean type obviously.
There was a problem hiding this comment.
62e1a05
I'm still not sure we understand each other, please take a look
ios/RNSScreen.h
Outdated
| /** | ||
| * Returns a boolean equivalent of fullScreenSwipeEnabled OptionalBoolean, resolves Undefined as `false` for iOS < 26, | ||
| * `true` otherwise. | ||
| */ | ||
| - (BOOL)fullScreenSwipeEnabledBoolean; |
There was a problem hiding this comment.
Yep, I could see fullScreenSwipeEnabled property being readonly, overwrite the getter to return appropriate BOOL value & we do not need any additional method here.
|
@kkafar @kmichalikk is it possible to use this prop with a vertical scroll view? somehow if i have scroll view from the gesture handler in the screen it won't swipe on iOS 26. only on the very edge. |
5 participants
Description
Resolves [iOS] Bring back fullScreenSwipeEnabled on iOS 26.
This PR brings back
fullScreenSwipeEnabledprop on iOS 26. The type of the prop is changed internally to OptionalBoolean with default value differing between versions.Test code and steps to reproduce
Use
Test3093