Skip to content

perf: add the cache_dir parameter #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 6, 2025
Merged

perf: add the cache_dir parameter #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31b40da
perf: add the cache_dir parameter
Crovitche-1623 Jul 4, 2025
3bc26d7
docs: Add instructions to use the cache directory
Crovitche-1623 Jul 4, 2025
d85104a
refactor: Adapt the code for PHP 7.1
Crovitche-1623 Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,14 @@ $isoCodes = new IsoCodesFactory(null, new GettextExtensionDriver());

// symfony driver
$driver = new SymfonyTranslationDriver();

// You can also specify a cache directory for better performance. If you are
// using the SymfonyTranslationDriver within a Symfony project, you can inject
// the `%kernel.cache_dir%/translations` value.
$cacheDir = '...';

$driver = new SymfonyTranslationDriver($cacheDir)

$driver->setLocale('uk_UA');

$isoCodes = new IsoCodesFactory(
Expand Down
4 changes: 2 additions & 2 deletions src/TranslationDriver/SymfonyTranslationDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ class SymfonyTranslationDriver implements TranslationDriverInterface
*/
private $locale = 'en';

public function __construct()
public function __construct(?string $cacheDirectory = null)
{
$this->translator = new Translator($this->locale);
$this->translator = new Translator($this->locale, null, $cacheDirectory);
$this->translator->addLoader('mo', new MoFileLoader());
}

Expand Down