-
Notifications
You must be signed in to change notification settings - Fork 305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to get one of my colleagues with more Rust experience to review this - @ASCorreia can you please check this out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above.
@ASCorreia sir if possible can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, a pretty good improvement from the previous state.
Some minor changes and a small rework might be needed, as stated in the review comments.
…if further changes are needed!
Thanks for the feedback! Let me know if further changes are needed! @ASCorreia @mikemaccana |
@mikemaccana Sir, I have resolved all the requests mentioned |
This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days. |
Problem
The original lesson on Rust Procedural Macros lacked depth in certain areas and needed updates to reflect current best practices.
Summary of Changes
syn
andquote
crates5.Enhanced Anchor procedural macros section