Skip to content
This repository was archived by the owner on Jan 24, 2025. It is now read-only.

Rust Procedural Macros Lesson #435

Closed
wants to merge 6 commits into from

Conversation

Ayushjhax
Copy link

Problem

The original lesson on Rust Procedural Macros lacked depth in certain areas and needed updates to reflect current best practices.

Summary of Changes

  1. Expanded Rust concepts section with more detailed explanations
  2. Added new subsections on syn and quote crates
  3. Updated and expanded code examples throughout
  4. Refined procedural macro example with step-by-step explanations
    5.Enhanced Anchor procedural macros section

Copy link
Contributor

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to get one of my colleagues with more Rust experience to review this - @ASCorreia can you please check this out?

Copy link
Contributor

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.

@Ayushjhax
Copy link
Author

@ASCorreia sir if possible can you review this?

Copy link
Contributor

@ASCorreia ASCorreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, a pretty good improvement from the previous state.

Some minor changes and a small rework might be needed, as stated in the review comments.

@Ayushjhax Ayushjhax closed this Sep 25, 2024
@Ayushjhax Ayushjhax reopened this Sep 25, 2024
@Ayushjhax
Copy link
Author

Thanks for the feedback! Let me know if further changes are needed! @ASCorreia @mikemaccana

@Ayushjhax
Copy link
Author

@mikemaccana Sir, I have resolved all the requests mentioned

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants