This repository was archived by the owner on Jan 24, 2025. It is now read-only.
fix and improve duplicate-mutable-accounts lesson #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….InitSpace.html) to calculate space needed for accounts. Delete Unnecessary parameters found in the test typescript. Consistently use "rpc()" as sending transactions in the test typescript.
….InitSpace.html) to calculate space needed for accounts. Replace "BorshDeserialize" and "BorshSerialize" with "AnchorDeserialize" and "AnchorSerialize". Make test descriptions more clear.
mikemaccana
reviewed
Oct 17, 2024
Comment on lines
+290
to
+291
| ... | ||
| it("Invoke insecure instruction with the same player should be successful", async () => { |
There was a problem hiding this comment.
Suggested change
| ... | |
| it("Invoke insecure instruction with the same player should be successful", async () => { | |
| ... | |
| it("Invokes insecure instruction with the same player successfully", async () => { |
There was a problem hiding this comment.
mikemaccana
suggested changes
Oct 17, 2024
Comment on lines
+290
to
+291
| ... | ||
| it("Invoke insecure instruction with the same player should be successful", async () => { |
There was a problem hiding this comment.
Comment on lines
+381
to
+382
| const p1 = await program.account.playerState.fetch(playerOne.publicKey); | ||
| const p2 = await program.account.playerState.fetch(playerTwo.publicKey); |
There was a problem hiding this comment.
player and player per 'use full names' https://github.com/solana-foundation/developer-content/blob/main/CONTRIBUTING.md#code
| const p1 = await program.account.playerState.fetch(playerOne.publicKey); | ||
| const p2 = await program.account.playerState.fetch(playerTwo.publicKey); | ||
| assert.equal(JSON.stringify(p1.choice), JSON.stringify({ rock: {} })); | ||
| assert.equal(JSON.stringify(p2.choice), JSON.stringify({ scissors: {} })); |
There was a problem hiding this comment.
Can we do this without the JSON.stringify()? assert.deepEqual() or similar?
| }) | ||
| .rpc() | ||
| .rpc(); | ||
| } catch (err) { |
There was a problem hiding this comment.
See https://github.com/solana-foundation/developer-content/blob/main/CONTRIBUTING.md#jsts
catch (thrownObject) {
const error = thrownObject as Error
...
}
| Push your code to GitHub and | ||
| [tell us what you thought of this lesson](https://form.typeform.com/to/IPH0UGz7#answers-lesson=9b759e39-7a06-4694-ab6d-e3e7ac266ea7)! | ||
| </Callout> | ||
| --- |
There was a problem hiding this comment.
This appears to be a second copy of the lesson!
mikemaccana
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Magic number found on space calculation.
"BorshDeserialize" and "BorshSerialize" are outdated.
Test descriptions are not clear enough.
Summary of Changes
Use InitSpace to calculate space needed for accounts.
Replace "BorshDeserialize" and "BorshSerialize" with "AnchorDeserialize" and "AnchorSerialize".
Make test descriptions more clear.
Also, I made a PR for solana-duplicate-mutable-accounts starter branch and a PR for solana-duplicate-mutable-accounts solution branch
which must be synced with this PR.